juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

[BUG]: Add timeseries_2d as valid input type for HDF5FeatureStorage #444

Merged
fraimondo merged 3 commits from patch/timeseries_2d into main 2025-04-25 12:54:39 +00:00
Conversation 2 Commits 3 Files changed 3 +16 -2
3 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changes/newsfragments/444.bugfix Normal file
View file

@ -0,0 +1 @@
Allow ``timeseries_2d`` storage for :class:`.HDF5FeatureStorage` by `Fede Raimondo`_

16
junifer/storage/hdf5.py
View file

@ -157,7 +157,13 @@ class HDF5FeatureStorage(BaseFeatureStorage):
uri.parent.mkdir(parents=True, exist_ok=True) uri.parent.mkdir(parents=True, exist_ok=True)
# Available storage kinds # Available storage kinds
storage_types = ["vector", "timeseries", "matrix", "scalar_table"] storage_types = [
"vector",
"timeseries",
"matrix",
"scalar_table",
"timeseries_2d",
]
super().__init__( super().__init__(
uri=uri, uri=uri,
@ -180,7 +186,13 @@ class HDF5FeatureStorage(BaseFeatureStorage):
storage. storage.
""" """
return ["matrix", "vector", "timeseries", "scalar_table"] return [
"matrix",
"vector",
"timeseries",
"scalar_table",
"timeseries_2d",
]
def _fetch_correct_uri_for_io(self, element: Optional[dict]) -> str: def _fetch_correct_uri_for_io(self, element: Optional[dict]) -> str:
"""Return proper URI for I/O based on `element`. """Return proper URI for I/O based on `element`.

1
junifer/storage/tests/test_hdf5.py
View file

@ -29,6 +29,7 @@ def test_get_valid_inputs() -> None:
"vector", "vector",
"timeseries", "timeseries",
"scalar_table", "scalar_table",
"timeseries_2d",
] ]