[BUG]: Add `timeseries_2d` as valid input type for `HDF5FeatureStorage` #444

Merged

fraimondo merged 3 commits from patch/timeseries_2d into main

2025-04-25 12:54:39 +00:00

fraimondo commented

2025-04-25 09:40:01 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes

codecov[bot] commented

2025-04-25 09:43:44 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (2bd28e2) to head (b9013e7).

❌ Your project check has failed because the head coverage (86.12%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   86.13%   86.13%   -0.01%     
==========================================
  Files         133      133              
  Lines        5619     5617       -2     
  Branches      950      950              
==========================================
- Hits         4840     4838       -2     
  Misses        600      600              
  Partials      179      179

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
junifer/storage/hdf5.py	`93.99% <ø> (-0.05%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/444?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 86.13%. Comparing base [(`2bd28e2`)](https://app.codecov.io/gh/juaml/junifer/commit/2bd28e2e8ffb1b8103b10157c7c2e1b17a06c457?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`b9013e7`)](https://app.codecov.io/gh/juaml/junifer/commit/b9013e7a306e7a56c0dc0483cc48ab53c9bb6787?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). :x: Your project check has failed because the head coverage (86.12%) is below the target coverage (90.00%). You can increase the head coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/444/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #444 +/- ## ========================================== - Coverage 86.13% 86.13% -0.01% ========================================== Files 133 133 Lines 5619 5617 -2 Branches 950 950 ========================================== - Hits 4840 4838 -2 Misses 600 600 Partials 179 179 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/444/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/444/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/444?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/storage/hdf5.py](https://app.codecov.io/gh/juaml/junifer/pull/444?src=pr&el=tree&filepath=junifer%2Fstorage%2Fhdf5.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL2hkZjUucHk=) | `93.99% <ø> (-0.05%)` | :arrow_down: | </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>

synchon (Migrated from github.com) approved these changes

2025-04-25 12:54:29 +00:00