From b9013e7a306e7a56c0dc0483cc48ab53c9bb6787 Mon Sep 17 00:00:00 2001 From: Fede Raimondo Date: Thu, 6 Feb 2025 10:00:09 +0100 Subject: [PATCH 1/3] Fix timeseries_2d storage issue --- junifer/storage/hdf5.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/junifer/storage/hdf5.py b/junifer/storage/hdf5.py index 7a083509a..99c2f406e 100644 --- a/junifer/storage/hdf5.py +++ b/junifer/storage/hdf5.py @@ -157,7 +157,13 @@ class HDF5FeatureStorage(BaseFeatureStorage): uri.parent.mkdir(parents=True, exist_ok=True) # Available storage kinds - storage_types = ["vector", "timeseries", "matrix", "scalar_table"] + storage_types = [ + "vector", + "timeseries", + "matrix", + "scalar_table", + "timeseries_2d", + ] super().__init__( uri=uri, @@ -180,7 +186,13 @@ class HDF5FeatureStorage(BaseFeatureStorage): storage. """ - return ["matrix", "vector", "timeseries", "scalar_table"] + return [ + "matrix", + "vector", + "timeseries", + "scalar_table", + "timeseries_2d", + ] def _fetch_correct_uri_for_io(self, element: Optional[dict]) -> str: """Return proper URI for I/O based on `element`. -- 2.52.0 From bccd0f241537a2697f4b66bcebbf6cd6e4d506c4 Mon Sep 17 00:00:00 2001 From: Synchon Mandal Date: Fri, 25 Apr 2025 12:23:34 +0200 Subject: [PATCH 2/3] fix: update tests for HDF5FeatureStorage --- junifer/storage/tests/test_hdf5.py | 1 + 1 file changed, 1 insertion(+) diff --git a/junifer/storage/tests/test_hdf5.py b/junifer/storage/tests/test_hdf5.py index 9f9adfb19..37e78f023 100644 --- a/junifer/storage/tests/test_hdf5.py +++ b/junifer/storage/tests/test_hdf5.py @@ -29,6 +29,7 @@ def test_get_valid_inputs() -> None: "vector", "timeseries", "scalar_table", + "timeseries_2d", ] -- 2.52.0 From b13787e5323f209185f169fe29681c8508596ce7 Mon Sep 17 00:00:00 2001 From: Synchon Mandal Date: Fri, 25 Apr 2025 13:03:25 +0200 Subject: [PATCH 3/3] chore: add changelog 444.bugfix --- docs/changes/newsfragments/444.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/changes/newsfragments/444.bugfix diff --git a/docs/changes/newsfragments/444.bugfix b/docs/changes/newsfragments/444.bugfix new file mode 100644 index 000000000..152633f24 --- /dev/null +++ b/docs/changes/newsfragments/444.bugfix @@ -0,0 +1 @@ +Allow ``timeseries_2d`` storage for :class:`.HDF5FeatureStorage` by `Fede Raimondo`_ -- 2.52.0