juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

[ENH]: Add missing decorators for BaseMarker and BasePreprocessor #214

Merged
synchon merged 4 commits from chore/missing-decorators into main 2023-03-30 13:03:34 +00:00
Conversation 3 Commits 4 Files changed 3 +3
3 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changes/newsfragments/214.enh Normal file
View file

@ -0,0 +1 @@
Add missing ``abstractmethod`` decorators for ``get_valid_inputs`` methods of :class:`junifer.markers.BaseMarker` and :class:`junifer.preprocess.BasePreprocessor` by `Synchon Mandal`_

1
junifer/markers/base.py
View file

@ -45,6 +45,7 @@ class BaseMarker(ABC, PipelineStepMixin, UpdateMetaMixin):
raise ValueError(f"{self.name} cannot be computed on {wrong_on}") raise ValueError(f"{self.name} cannot be computed on {wrong_on}")
self._on = on self._on = on
@abstractmethod
def get_valid_inputs(self) -> List[str]: def get_valid_inputs(self) -> List[str]:
"""Get valid data types for input. """Get valid data types for input.

1
junifer/preprocess/base.py
View file

@ -79,6 +79,7 @@ class BasePreprocessor(ABC, PipelineStepMixin, UpdateMetaMixin):
klass=NotImplementedError, klass=NotImplementedError,
) )
@abstractmethod
def get_valid_inputs(self) -> List[str]: def get_valid_inputs(self) -> List[str]:
"""Get valid data types for input. """Get valid data types for input.