From 59140f5e0c1d52107b0f4cf6cf0701222e777a16 Mon Sep 17 00:00:00 2001 From: Synchon Mandal Date: Thu, 30 Mar 2023 12:26:03 +0200 Subject: [PATCH 1/4] chore: add missing abstractmethod decorator for BaseMarker --- junifer/markers/base.py | 1 + 1 file changed, 1 insertion(+) diff --git a/junifer/markers/base.py b/junifer/markers/base.py index ba1c03da2..c78097c5d 100644 --- a/junifer/markers/base.py +++ b/junifer/markers/base.py @@ -45,6 +45,7 @@ class BaseMarker(ABC, PipelineStepMixin, UpdateMetaMixin): raise ValueError(f"{self.name} cannot be computed on {wrong_on}") self._on = on + @abstractmethod def get_valid_inputs(self) -> List[str]: """Get valid data types for input. -- 2.52.0 From 152a2218338da63a8dc35fcb0cdf633b70d34347 Mon Sep 17 00:00:00 2001 From: Synchon Mandal Date: Thu, 30 Mar 2023 12:26:37 +0200 Subject: [PATCH 2/4] chore: add missing abstractmethod decorator for BasePreprocessor --- junifer/preprocess/base.py | 1 + 1 file changed, 1 insertion(+) diff --git a/junifer/preprocess/base.py b/junifer/preprocess/base.py index c9f8b97e9..2423cc251 100644 --- a/junifer/preprocess/base.py +++ b/junifer/preprocess/base.py @@ -79,6 +79,7 @@ class BasePreprocessor(ABC, PipelineStepMixin, UpdateMetaMixin): klass=NotImplementedError, ) + @abstractmethod def get_valid_inputs(self) -> List[str]: """Get valid data types for input. -- 2.52.0 From 31d499c056eade8f6899a18afea34c5445a4a335 Mon Sep 17 00:00:00 2001 From: Synchon Mandal Date: Thu, 30 Mar 2023 13:30:58 +0200 Subject: [PATCH 3/4] chore: add changelog file 214.enh --- docs/changes/newsfragments/214.enh | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/changes/newsfragments/214.enh diff --git a/docs/changes/newsfragments/214.enh b/docs/changes/newsfragments/214.enh new file mode 100644 index 000000000..8d22c9224 --- /dev/null +++ b/docs/changes/newsfragments/214.enh @@ -0,0 +1 @@ +Add missing ``abstractmethod`` decorators for ``get_valid_inputs`` methods of :class:`junifer.markers.BaseMarker` and :class:`junifer.preprocess.BasePreprocessor`. \ No newline at end of file -- 2.52.0 From dc509867595fc1b6b1660d03719a36224a388a2d Mon Sep 17 00:00:00 2001 From: Synchon Mandal Date: Thu, 30 Mar 2023 14:06:08 +0200 Subject: [PATCH 4/4] chore: add author in changelog 214.enh --- docs/changes/newsfragments/214.enh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/changes/newsfragments/214.enh b/docs/changes/newsfragments/214.enh index 8d22c9224..dcd629ae6 100644 --- a/docs/changes/newsfragments/214.enh +++ b/docs/changes/newsfragments/214.enh @@ -1 +1 @@ -Add missing ``abstractmethod`` decorators for ``get_valid_inputs`` methods of :class:`junifer.markers.BaseMarker` and :class:`junifer.preprocess.BasePreprocessor`. \ No newline at end of file +Add missing ``abstractmethod`` decorators for ``get_valid_inputs`` methods of :class:`junifer.markers.BaseMarker` and :class:`junifer.preprocess.BasePreprocessor` by `Synchon Mandal`_ \ No newline at end of file -- 2.52.0