[ENH]: Add missing decorators for `BaseMarker` and `BasePreprocessor` #214

Merged

synchon merged 4 commits from chore/missing-decorators into main

2023-03-30 13:03:34 +00:00

synchon commented

2023-03-30 11:10:17 +00:00

(Migrated from github.com)

fix #(issue number)
description of feature/fix
tests added/passed
add an entry for the latest changes

This PR adds missing abstractmethod decorators for get_valid_inputs methods of BaseMarker and BasePreprocessor.

* [ ] fix #(issue number) * [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR adds missing `abstractmethod` decorators for `get_valid_inputs` methods of `BaseMarker` and `BasePreprocessor`.

github-actions[bot] commented

2023-03-30 11:20:15 +00:00

(Migrated from github.com)

PR Preview Action v1.3.0
Preview removed because the pull request was closed.
2023-03-30 13:09 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.3.0 :---: Preview removed because the pull request was closed. 2023-03-30 13:09 UTC

codecov[bot] commented

2023-03-30 11:31:55 +00:00

(Migrated from github.com)

Codecov Report

Merging #214 (dc50986) into main (04a8d26) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          80       80           
  Lines        3435     3437    +2     
  Branches      644      644           
=======================================
+ Hits         3206     3208    +2     
  Misses        151      151           
  Partials       78       78

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`93.32% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/markers/base.py	`94.00% <100.00%> (+0.12%)`	⬆️
junifer/preprocess/base.py	`85.36% <100.00%> (+0.36%)`	⬆️

## [Codecov](https://codecov.io/gh/juaml/junifer/pull/214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#214](https://codecov.io/gh/juaml/junifer/pull/214?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (dc50986) into [main](https://codecov.io/gh/juaml/junifer/commit/04a8d260a27779a1a6cb1717217d67ac9bc73866?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (04a8d26) will **increase** coverage by `0.00%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/214/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #214 +/- ## ======================================= Coverage 93.33% 93.33% ======================================= Files 80 80 Lines 3435 3437 +2 Branches 644 644 ======================================= + Hits 3206 3208 +2 Misses 151 151 Partials 78 78 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.32% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/markers/base.py](https://codecov.io/gh/juaml/junifer/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2Jhc2UucHk=) | `94.00% <100.00%> (+0.12%)` | :arrow_up: | | [junifer/preprocess/base.py](https://codecov.io/gh/juaml/junifer/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9wcmVwcm9jZXNzL2Jhc2UucHk=) | `85.36% <100.00%> (+0.36%)` | :arrow_up: |

fraimondo (Migrated from github.com) approved these changes

2023-03-30 12:50:37 +00:00