Enh/default single output #135

Merged

fraimondo merged 6 commits from enh/default_single_output into main

2022-11-21 19:27:31 +00:00

fraimondo commented

2022-11-21 14:55:08 +00:00

(Migrated from github.com)

fix #134
description of feature/fix
tests added/passed
add an entry to the latest changes

* [x] fix #134 * [x] description of feature/fix * [x] tests added/passed * [x] add an entry to the [latest changes](../docs/changes/latest.inc)

codecov[bot] commented

2022-11-21 14:55:31 +00:00

(Migrated from github.com)

Codecov Report

Merging #135 (a6c757b) into main (1aca7b8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   95.08%   95.09%           
=======================================
  Files          57       57           
  Lines        2260     2264    +4     
  Branches      424      426    +2     
=======================================
+ Hits         2149     2153    +4     
  Misses         71       71           
  Partials       40       40

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`95.08% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/storage/base.py	`94.11% <ø> (ø)`
junifer/storage/pandas_base.py	`100.00% <ø> (ø)`
junifer/api/functions.py	`98.03% <100.00%> (+0.05%)`	⬆️
junifer/storage/sqlite.py	`93.75% <100.00%> (ø)`

# [Codecov](https://codecov.io/gh/juaml/junifer/pull/135?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#135](https://codecov.io/gh/juaml/junifer/pull/135?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (a6c757b) into [main](https://codecov.io/gh/juaml/junifer/commit/1aca7b8efbffd44ba93e898b7f096a679b09a7d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (1aca7b8) will **increase** coverage by `0.00%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/135/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #135 +/- ## ======================================= Coverage 95.08% 95.09% ======================================= Files 57 57 Lines 2260 2264 +4 Branches 424 426 +2 ======================================= + Hits 2149 2153 +4 Misses 71 71 Partials 40 40 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `95.08% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/storage/base.py](https://codecov.io/gh/juaml/junifer/pull/135/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL2Jhc2UucHk=) | `94.11% <ø> (ø)` | | | [junifer/storage/pandas\_base.py](https://codecov.io/gh/juaml/junifer/pull/135/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL3BhbmRhc19iYXNlLnB5) | `100.00% <ø> (ø)` | | | [junifer/api/functions.py](https://codecov.io/gh/juaml/junifer/pull/135/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZnVuY3Rpb25zLnB5) | `98.03% <100.00%> (+0.05%)` | :arrow_up: | | [junifer/storage/sqlite.py](https://codecov.io/gh/juaml/junifer/pull/135/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL3NxbGl0ZS5weQ==) | `93.75% <100.00%> (ø)` | |

github-actions[bot] commented

2022-11-21 15:00:23 +00:00

(Migrated from github.com)

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2022-11-21 19:32 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.2.0 :---: Preview removed because the pull request was closed. 2022-11-21 19:32 UTC

synchon (Migrated from github.com) reviewed

2022-11-21 15:43:06 +00:00

synchon (Migrated from github.com) left a comment

Looks good! Can you please run black once?

Looks good! Can you please run `black` once?

fraimondo commented

2022-11-21 16:09:16 +00:00

(Migrated from github.com)