[ENH]: Change storage default parameter `single_output` to `True` #134

New issue

Closed

opened 2022-11-21 14:52:21 +00:00 by fraimondo · 0 comments

fraimondo commented

2022-11-21 14:52:21 +00:00

(Migrated from github.com)

Are you requiring a new dataset or marker?

I understand this is not a marker or dataset request

Which feature do you want to include?

Using a Storage requires the user to specify the URI and single_output=True, which is counter-intuitive and does not make any sense.

The only reason why we want False is for the run and collect functions. Because this functions are meant to create one file per subject (single_output=False).

The fix is to set that parameter to False in those functions (if not specified by the user) and leave the default as True, so it's easier to use the python interface to read features.

How do you imagine this integrated in junifer?

Done it, will submit the PR now.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

### Are you requiring a new dataset or marker? - [X] I understand this is not a marker or dataset request ### Which feature do you want to include? Using a Storage requires the user to specify the URI and `single_output=True`, which is counter-intuitive and does not make any sense. The only reason why we want `False` is for the `run` and `collect` functions. Because this functions are meant to create one file per subject (`single_output=False`). The fix is to set that parameter to `False` in those functions (if not specified by the user) and leave the default as `True`, so it's easier to use the python interface to read features. ### How do you imagine this integrated in junifer? Done it, will submit the PR now. ### Do you have a sample code that implements this outside of junifer? _No response_ ### Anything else to say? _No response_