juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

[ENH]: Improve Marker interface #477

Merged
synchon merged 6 commits from refactor/marker into main 2025-11-17 15:11:12 +00:00
Conversation 4 Commits 6 Files changed 30 +72 -71
synchon commented 2025-11-12 17:16:30 +00:00 (Migrated from github.com)
Copy link
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR improves the Marker interface to simplify implementations.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR improves the `Marker` interface to simplify implementations.
synchon commented 2025-11-12 17:53:18 +00:00 (Migrated from github.com)
Copy link

CI passes on juseless.

CI passes on juseless.
github-actions[bot] commented 2025-11-12 18:04:50 +00:00 (Migrated from github.com)
Copy link
PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-11-17 15:58 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.6.2 :---: Preview removed because the pull request was closed. 2025-11-17 15:58 UTC <!-- Sticky Pull Request Commentpr-preview -->
fraimondo (Migrated from github.com) requested changes 2025-11-12 18:35:46 +00:00
junifer/markers/base.py
@ -6,10 +6,10 @@
fraimondo (Migrated from github.com) commented 2025-11-12 18:30:47 +00:00
Copy link

This is MRI-specific and should not be here.

This is MRI-specific and should not be here.
junifer/markers/ets_rss.py
fraimondo (Migrated from github.com) commented 2025-11-12 18:32:06 +00:00
Copy link

masks should be on the marker.

masks should be on the marker.
junifer/markers/functional_connectivity/crossparcellation_functional_connectivity.py
fraimondo (Migrated from github.com) commented 2025-11-12 18:33:10 +00:00
Copy link

Same with respect to masks

Same with respect to masks
junifer/markers/functional_connectivity/functional_connectivity_base.py
fraimondo (Migrated from github.com) commented 2025-11-12 18:33:30 +00:00
Copy link

Masks should be on the base FC

Masks should be on the base FC
junifer/markers/maps_aggregation.py
fraimondo (Migrated from github.com) commented 2025-11-12 18:34:04 +00:00
Copy link

Masks should be in the MapsAggregation

Masks should be in the MapsAggregation
junifer/markers/parcel_aggregation.py
fraimondo (Migrated from github.com) commented 2025-11-12 18:34:14 +00:00
Copy link

Same as before

Same as before
junifer/markers/reho/reho_base.py
fraimondo (Migrated from github.com) commented 2025-11-12 18:34:45 +00:00
Copy link

Masks should be stored here.

Masks should be stored here.
junifer/markers/sphere_aggregation.py
fraimondo (Migrated from github.com) commented 2025-11-12 18:35:08 +00:00
Copy link

Masks should be stored here.

Masks should be stored here.
junifer/markers/temporal_snr/temporal_snr_base.py
fraimondo (Migrated from github.com) commented 2025-11-12 18:35:19 +00:00
Copy link

Masks should be stored here

Masks should be stored here
fraimondo (Migrated from github.com) approved these changes 2025-11-17 13:59:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fraimondo
Labels
Clear labels   
CRITICAL
High Priority Issue

  
Stale

   
WIP
Work in progress

  
bug
Something isn't working

  
concept
Design/Implementation concepts

  
coordinate
Issues or pull requests related to coordinates (ROIs)

  
dataset
Issues or pull requests related to datagrabbers or datasets

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
maintenance
Issues or pull requests related to maintenance

  
maps
Issues or pull requests related to maps (probabilistic atlases)

  
marker
Issues or pull requests related to markers

  
mask
Issues or pull requests related to masks

  
on hold
Issue waiting on other issue(s)

  
parcellation
Issues or pull requests related to parcellations (deterministic atlases)

  
preprocess
Issues or pull requests related to preprocessors

  
question
Further information is requested

  
ready
Pull request is ready for review and merge

  
storage
Issues or pull requests related to marker storage or retrieval

  
template-space
Issues or pull requests related to template spaces

  
triage
New issues waiting to be reviewed

  
wontfix
This will not be worked on

No labels
CRITICAL
Stale
WIP
bug
concept
coordinate
dataset
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
maintenance
maps
marker
mask
on hold
parcellation
preprocess
question
ready
storage
template-space
triage
wontfix
Milestone
Clear milestone
No items
No milestone
0.0.7 (alpha 6)
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!477
No description provided.