[ENH]: Introduce maps variants of markers #460

Merged
synchon merged 15 commits from feat/maps-marker-variants into main 2025-09-08 12:08:38 +00:00
synchon commented 2025-08-20 15:37:03 +00:00 (Migrated from github.com)
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduce maps variants of markers, namely:

  • MapsAggregation
  • FunctionalConnectivityMaps
  • EdgeCentricFCMaps
  • ReHoMaps
  • ALFFMaps
  • TemporalSNRMaps
* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR introduce maps variants of markers, namely: - MapsAggregation - FunctionalConnectivityMaps - EdgeCentricFCMaps - ReHoMaps - ALFFMaps - TemporalSNRMaps
codecov[bot] commented 2025-08-20 15:37:29 +00:00 (Migrated from github.com)

Codecov Report

❌ Patch coverage is 98.49624% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.67%. Comparing base (42a09b3) to head (b7930ee).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
junifer/markers/reho/reho_maps.py 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   91.45%   91.67%   +0.22%     
==========================================
  Files         140      146       +6     
  Lines        5887     6019     +132     
  Branches      956      962       +6     
==========================================
+ Hits         5384     5518     +134     
+ Misses        325      324       -1     
+ Partials      178      177       -1     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 91.67% <98.49%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/conftest.py 100.00% <100.00%> (ø)
junifer/markers/falff/falff_maps.py 100.00% <100.00%> (ø)
..._connectivity/edge_functional_connectivity_maps.py 100.00% <100.00%> (ø)
...ional_connectivity/functional_connectivity_maps.py 100.00% <100.00%> (ø)
junifer/markers/maps_aggregation.py 100.00% <100.00%> (ø)
junifer/markers/temporal_snr/temporal_snr_maps.py 100.00% <100.00%> (ø)
junifer/typing/_typing.py 100.00% <100.00%> (ø)
junifer/markers/reho/reho_maps.py 91.66% <91.66%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/460?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report :x: Patch coverage is `98.49624%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 91.67%. Comparing base ([`42a09b3`](https://app.codecov.io/gh/juaml/junifer/commit/42a09b3a72e5b81a447a222d6184bf29db9ea42a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)) to head ([`b7930ee`](https://app.codecov.io/gh/juaml/junifer/commit/b7930eef4d18c23bf145e8f0322cb6f4d837e512?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)). :warning: Report is 16 commits behind head on main. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/460?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Patch % | Lines | |---|---|---| | [junifer/markers/reho/reho\_maps.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Fmarkers%2Freho%2Freho_maps.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL3JlaG8vcmVob19tYXBzLnB5) | 91.66% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/460/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #460 +/- ## ========================================== + Coverage 91.45% 91.67% +0.22% ========================================== Files 140 146 +6 Lines 5887 6019 +132 Branches 956 962 +6 ========================================== + Hits 5384 5518 +134 + Misses 325 324 -1 + Partials 178 177 -1 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/460/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `91.67% <98.49%> (+0.22%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/460?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/conftest.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Fconftest.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9jb25mdGVzdC5weQ==) | `100.00% <100.00%> (ø)` | | | [junifer/markers/falff/falff\_maps.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Fmarkers%2Ffalff%2Ffalff_maps.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2ZhbGZmL2ZhbGZmX21hcHMucHk=) | `100.00% <100.00%> (ø)` | | | [...\_connectivity/edge\_functional\_connectivity\_maps.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Fmarkers%2Ffunctional_connectivity%2Fedge_functional_connectivity_maps.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2Z1bmN0aW9uYWxfY29ubmVjdGl2aXR5L2VkZ2VfZnVuY3Rpb25hbF9jb25uZWN0aXZpdHlfbWFwcy5weQ==) | `100.00% <100.00%> (ø)` | | | [...ional\_connectivity/functional\_connectivity\_maps.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Fmarkers%2Ffunctional_connectivity%2Ffunctional_connectivity_maps.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2Z1bmN0aW9uYWxfY29ubmVjdGl2aXR5L2Z1bmN0aW9uYWxfY29ubmVjdGl2aXR5X21hcHMucHk=) | `100.00% <100.00%> (ø)` | | | [junifer/markers/maps\_aggregation.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Fmarkers%2Fmaps_aggregation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL21hcHNfYWdncmVnYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [junifer/markers/temporal\_snr/temporal\_snr\_maps.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Fmarkers%2Ftemporal_snr%2Ftemporal_snr_maps.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL3RlbXBvcmFsX3Nuci90ZW1wb3JhbF9zbnJfbWFwcy5weQ==) | `100.00% <100.00%> (ø)` | | | [junifer/typing/\_typing.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Ftyping%2F_typing.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci90eXBpbmcvX3R5cGluZy5weQ==) | `100.00% <100.00%> (ø)` | | | [junifer/markers/reho/reho\_maps.py](https://app.codecov.io/gh/juaml/junifer/pull/460?src=pr&el=tree&filepath=junifer%2Fmarkers%2Freho%2Freho_maps.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL3JlaG8vcmVob19tYXBzLnB5) | `91.66% <91.66%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/juaml/junifer/pull/460/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>
github-actions[bot] commented 2025-08-20 16:21:32 +00:00 (Migrated from github.com)
PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-08 12:47 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.6.2 :---: Preview removed because the pull request was closed. 2025-09-08 12:47 UTC <!-- Sticky Pull Request Commentpr-preview -->
fraimondo (Migrated from github.com) approved these changes 2025-09-08 06:47:29 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!460
No description provided.