[MAINT]: Repository maintenance #441

Merged
synchon merged 24 commits from chore/ruff-format into main 2025-04-10 11:08:49 +00:00
synchon commented 2025-03-24 11:57:43 +00:00 (Migrated from github.com)
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR does general repository maintenance by updating .pre-commit-config.yaml, replacing black with ruff-format and updating tool configs.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR does general repository maintenance by updating `.pre-commit-config.yaml`, replacing `black` with `ruff-format` and updating tool configs.
codecov[bot] commented 2025-03-24 11:58:05 +00:00 (Migrated from github.com)

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.00%. Comparing base (4e30385) to head (6764fda).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
junifer/utils/logging.py 83.33% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (91.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   85.77%   91.00%   +5.22%     
==========================================
  Files         133      133              
  Lines        5675     5359     -316     
  Branches      962      893      -69     
==========================================
+ Hits         4868     4877       +9     
+ Misses        618      309     -309     
+ Partials      189      173      -16     
Flag Coverage Δ
junifer 91.00% <91.66%> (+5.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/api/decorators.py 100.00% <ø> (ø)
junifer/api/functions.py 91.36% <ø> (ø)
...er/api/queue_context/gnu_parallel_local_adapter.py 92.92% <ø> (ø)
junifer/api/queue_context/htcondor_adapter.py 96.00% <100.00%> (ø)
junifer/data/_dispatch.py 95.34% <ø> (+57.84%) ⬆️
...nifer/data/coordinates/_ants_coordinates_warper.py 100.00% <ø> (+61.90%) ⬆️
junifer/data/coordinates/_coordinates.py 100.00% <ø> (+20.28%) ⬆️
...unifer/data/coordinates/_fsl_coordinates_warper.py 100.00% <ø> (+50.00%) ⬆️
junifer/data/masks/_ants_mask_warper.py 76.92% <ø> (+49.42%) ⬆️
junifer/data/masks/_fsl_mask_warper.py 75.00% <ø> (+27.38%) ⬆️
... and 32 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/441?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report Attention: Patch coverage is `91.66667%` with `1 line` in your changes missing coverage. Please review. > Project coverage is 91.00%. Comparing base [(`4e30385`)](https://app.codecov.io/gh/juaml/junifer/commit/4e30385ab57312e54b904ca64dbf59aeeff8ef64?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`6764fda`)](https://app.codecov.io/gh/juaml/junifer/commit/6764fda72ba022622ca6997b92b74cee9d42fbed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 25 commits behind head on main. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/441?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Patch % | Lines | |---|---|---| | [junifer/utils/logging.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Futils%2Flogging.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci91dGlscy9sb2dnaW5nLnB5) | 83.33% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | :x: Your patch status has failed because the patch coverage (91.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/441/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #441 +/- ## ========================================== + Coverage 85.77% 91.00% +5.22% ========================================== Files 133 133 Lines 5675 5359 -316 Branches 962 893 -69 ========================================== + Hits 4868 4877 +9 + Misses 618 309 -309 + Partials 189 173 -16 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/441/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/441/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `91.00% <91.66%> (+5.22%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/441?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/api/decorators.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fapi%2Fdecorators.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZGVjb3JhdG9ycy5weQ==) | `100.00% <ø> (ø)` | | | [junifer/api/functions.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fapi%2Ffunctions.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZnVuY3Rpb25zLnB5) | `91.36% <ø> (ø)` | | | [...er/api/queue\_context/gnu\_parallel\_local\_adapter.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fapi%2Fqueue_context%2Fgnu_parallel_local_adapter.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvcXVldWVfY29udGV4dC9nbnVfcGFyYWxsZWxfbG9jYWxfYWRhcHRlci5weQ==) | `92.92% <ø> (ø)` | | | [junifer/api/queue\_context/htcondor\_adapter.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fapi%2Fqueue_context%2Fhtcondor_adapter.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvcXVldWVfY29udGV4dC9odGNvbmRvcl9hZGFwdGVyLnB5) | `96.00% <100.00%> (ø)` | | | [junifer/data/\_dispatch.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fdata%2F_dispatch.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL19kaXNwYXRjaC5weQ==) | `95.34% <ø> (+57.84%)` | :arrow_up: | | [...nifer/data/coordinates/\_ants\_coordinates\_warper.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fdata%2Fcoordinates%2F_ants_coordinates_warper.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL2Nvb3JkaW5hdGVzL19hbnRzX2Nvb3JkaW5hdGVzX3dhcnBlci5weQ==) | `100.00% <ø> (+61.90%)` | :arrow_up: | | [junifer/data/coordinates/\_coordinates.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fdata%2Fcoordinates%2F_coordinates.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL2Nvb3JkaW5hdGVzL19jb29yZGluYXRlcy5weQ==) | `100.00% <ø> (+20.28%)` | :arrow_up: | | [...unifer/data/coordinates/\_fsl\_coordinates\_warper.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fdata%2Fcoordinates%2F_fsl_coordinates_warper.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL2Nvb3JkaW5hdGVzL19mc2xfY29vcmRpbmF0ZXNfd2FycGVyLnB5) | `100.00% <ø> (+50.00%)` | :arrow_up: | | [junifer/data/masks/\_ants\_mask\_warper.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fdata%2Fmasks%2F_ants_mask_warper.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL21hc2tzL19hbnRzX21hc2tfd2FycGVyLnB5) | `76.92% <ø> (+49.42%)` | :arrow_up: | | [junifer/data/masks/\_fsl\_mask\_warper.py](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree&filepath=junifer%2Fdata%2Fmasks%2F_fsl_mask_warper.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL21hc2tzL19mc2xfbWFza193YXJwZXIucHk=) | `75.00% <ø> (+27.38%)` | :arrow_up: | | ... and [32 more](https://app.codecov.io/gh/juaml/junifer/pull/441?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/juaml/junifer/pull/441/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>
github-actions[bot] commented 2025-03-24 12:40:08 +00:00 (Migrated from github.com)
PR Preview Action v1.6.0

🚀 View preview at
https://juaml.github.io/junifer/pr-preview/pr-441/

Built to branch gh-pages at 2025-04-03 16:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.6.0 :---: | <p></p> :rocket: View preview at <br> https://juaml.github.io/junifer/pr-preview/pr-441/ <br><br> | <h6>Built to branch [`gh-pages`](https://github.com/juaml/junifer/tree/gh-pages) at 2025-04-03 16:51 UTC. <br> Preview will be ready when the [GitHub Pages deployment](https://github.com/juaml/junifer/deployments) is complete. <br><br> </h6> <!-- Sticky Pull Request Commentpr-preview -->
fraimondo (Migrated from github.com) reviewed 2025-03-28 08:38:18 +00:00
fraimondo (Migrated from github.com) left a comment

Doesn't this PR needs to be rebased or merged on top of another? Seems that its adding covereage and adding the coordinates registry.

Doesn't this PR needs to be rebased or merged on top of another? Seems that its adding covereage and adding the coordinates registry.
synchon commented 2025-03-28 09:34:54 +00:00 (Migrated from github.com)

This PR is already rebased on main and it's removing the leftover files from coordinates and masks.

This PR is already rebased on main and it's removing the leftover files from coordinates and masks.
synchon commented 2025-04-07 09:05:46 +00:00 (Migrated from github.com)

@fraimondo should be good for review now, the patch coverage is red but it's not a problem.

@fraimondo should be good for review now, the patch coverage is red but it's not a problem.
synchon commented 2025-04-10 10:10:25 +00:00 (Migrated from github.com)

@fraimondo Can we get this in or do you have some review comments?

@fraimondo Can we get this in or do you have some review comments?
fraimondo (Migrated from github.com) approved these changes 2025-04-10 10:25:18 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!441
No description provided.