Power2011 and Power2013 files contain the same coordinates with mismatched ROI numbering #436

Merged

synchon merged 3 commits from chore/remove-power2013-coords into main

2025-03-13 16:58:21 +00:00

synchon commented

2025-03-13 16:05:51 +00:00

(Migrated from github.com)

Power2011_MNI_VOIs.txt and Power2013_MNI_VOIs.tsv contain the same coordinates with different ROI numbers. This creates the illusion that they are different when they are not and leads to dissimilarities, e.g. when computing FC, simply because of the ROI ordering.

I would suggest deleting the Power2013_MNI_VOIs.tsv, since Power et al., 2013 did not introduce new coordinates but reused the ones from Power et al. (2011) with unmatching ROI numbering.

From Method section of Power et al. (2013)

Node Definitions
For the areal network, a collection of 264 ROIs defined in Power et al. (2011) were used as network nodes [...]

`Power2011_MNI_VOIs.txt` and `Power2013_MNI_VOIs.tsv` contain the same coordinates with different ROI numbers. This creates the illusion that they are different when they are not and leads to dissimilarities, e.g. when computing FC, simply because of the ROI ordering. I would suggest deleting the `Power2013_MNI_VOIs.tsv`, since Power et al., 2013 did not introduce new coordinates but reused the ones from Power et al. (2011) with unmatching ROI numbering. **From Method section of Power et al. (2013)** > **Node Definitions** > For the areal network, a collection of 264 ROIs defined in Power et al. (2011) were used as network nodes [...]

synchon commented

2025-03-12 15:25:29 +00:00

(Migrated from github.com)

That's a great observation and thanks for the report, will remove it.

codecov[bot] commented

2025-03-13 16:06:37 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (b6e9852) to head (8add467).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         133      133           
  Lines        5658     5658           
  Branches      958      958           
=======================================
  Hits         4851     4851           
  Misses        618      618           
  Partials      189      189

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`85.73% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
junifer/data/coordinates/_coordinates.py	`79.71% <ø> (ø)`

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/436?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 85.73%. Comparing base [(`b6e9852`)](https://app.codecov.io/gh/juaml/junifer/commit/b6e98526e825a5a3e24a215f7be7d25c505d5fb3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`8add467`)](https://app.codecov.io/gh/juaml/junifer/commit/8add4678c5bb9bc1d50039d28e0c202959ab721b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/436/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #436 +/- ## ======================================= Coverage 85.73% 85.73% ======================================= Files 133 133 Lines 5658 5658 Branches 958 958 ======================================= Hits 4851 4851 Misses 618 618 Partials 189 189 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/436/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/436/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/436/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `85.73% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/436?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/data/coordinates/\_coordinates.py](https://app.codecov.io/gh/juaml/junifer/pull/436?src=pr&el=tree&filepath=junifer%2Fdata%2Fcoordinates%2F_coordinates.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL2Nvb3JkaW5hdGVzL19jb29yZGluYXRlcy5weQ==) | `79.71% <ø> (ø)` | | </details> <details><summary>🚀 New features to boost your workflow: </summary> - ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>

github-actions[bot] commented

2025-03-13 16:48:42 +00:00

(Migrated from github.com)

PR Preview Action v1.6.0
🚀 View preview at https://juaml.github.io/junifer/pr-preview/pr-436/
Built to branch `gh-pages` at 2025-03-13 16:44 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.6.0 :---: | <p></p> :rocket: View preview at <br> https://juaml.github.io/junifer/pr-preview/pr-436/ <br><br> | <h6>Built to branch [`gh-pages`](https://github.com/juaml/junifer/tree/gh-pages) at 2025-03-13 16:44 UTC. <br> Preview will be ready when the [GitHub Pages deployment](https://github.com/juaml/junifer/deployments) is complete. <br><br> </h6>