juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

[ENH]: Add TemporalFilter #432

Merged
fraimondo merged 7 commits from enh/temporal_filter into main 2025-07-21 14:28:41 +00:00
Conversation 4 Commits 7 Files changed 6 +347
fraimondo commented 2025-02-26 21:36:36 +00:00 (Migrated from github.com)
Copy link
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR adds TemporalFilter to filter / clean BOLD data via nilean.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR adds `TemporalFilter` to filter / clean BOLD data via nilean.
codecov[bot] commented 2025-02-26 22:16:23 +00:00 (Migrated from github.com)
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.26%. Comparing base (e153dcf) to head (311602d).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   91.17%   91.26%   +0.09%     
==========================================
  Files         134      135       +1     
  Lines        5507     5566      +59     
  Branches      903      905       +2     
==========================================
+ Hits         5021     5080      +59     
  Misses        313      313              
  Partials      173      173
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 91.26% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/pipeline/pipeline_component_registry.py 94.64% <ø> (ø)
junifer/preprocess/_temporal_filter.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/432?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 91.26%. Comparing base [(`e153dcf`)](https://app.codecov.io/gh/juaml/junifer/commit/e153dcfe23d191c54c08067573513a5f15ee022f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`311602d`)](https://app.codecov.io/gh/juaml/junifer/commit/311602dacaa3a022b1953d7e7c00780ba831b631?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 8 commits behind head on main. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/432/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #432 +/- ## ========================================== + Coverage 91.17% 91.26% +0.09% ========================================== Files 134 135 +1 Lines 5507 5566 +59 Branches 903 905 +2 ========================================== + Hits 5021 5080 +59 Misses 313 313 Partials 173 173 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/432/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `91.26% <100.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/432?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/pipeline/pipeline\_component\_registry.py](https://app.codecov.io/gh/juaml/junifer/pull/432?src=pr&el=tree&filepath=junifer%2Fpipeline%2Fpipeline_component_registry.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9waXBlbGluZS9waXBlbGluZV9jb21wb25lbnRfcmVnaXN0cnkucHk=) | `94.64% <ø> (ø)` | | | [junifer/preprocess/\_temporal\_filter.py](https://app.codecov.io/gh/juaml/junifer/pull/432?src=pr&el=tree&filepath=junifer%2Fpreprocess%2F_temporal_filter.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9wcmVwcm9jZXNzL190ZW1wb3JhbF9maWx0ZXIucHk=) | `100.00% <100.00%> (ø)` | | </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. </details>
github-actions[bot] commented 2025-02-26 22:21:05 +00:00 (Migrated from github.com)
Copy link
PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-07-21 15:06 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.6.2 :---: Preview removed because the pull request was closed. 2025-07-21 15:06 UTC <!-- Sticky Pull Request Commentpr-preview -->
fraimondo (Migrated from github.com) reviewed 2025-07-21 13:00:15 +00:00
fraimondo (Migrated from github.com) left a comment
Copy link

Can't approve the PR cause I'm the author. Feel free to go ahead. Just that typo I mentioned before. Rest is OK.

Can't approve the PR cause I'm the author. Feel free to go ahead. Just that typo I mentioned before. Rest is OK.
junifer/preprocess/_temporal_filter.py
@ -0,0 +1,240 @@
"""Provide class for temporal filtering."""
fraimondo (Migrated from github.com) commented 2025-07-21 12:02:05 +00:00
Copy link

Copy/paste error. It should say filtered data

Copy/paste error. It should say `filtered data`
synchon (Migrated from github.com) approved these changes 2025-07-21 14:28:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
synchon
Labels
Clear labels   
CRITICAL
High Priority Issue

  
Stale

   
WIP
Work in progress

  
bug
Something isn't working

  
concept
Design/Implementation concepts

  
coordinate
Issues or pull requests related to coordinates (ROIs)

  
dataset
Issues or pull requests related to datagrabbers or datasets

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
maintenance
Issues or pull requests related to maintenance

  
maps
Issues or pull requests related to maps (probabilistic atlases)

  
marker
Issues or pull requests related to markers

  
mask
Issues or pull requests related to masks

  
on hold
Issue waiting on other issue(s)

  
parcellation
Issues or pull requests related to parcellations (deterministic atlases)

  
preprocess
Issues or pull requests related to preprocessors

  
question
Further information is requested

  
ready
Pull request is ready for review and merge

  
storage
Issues or pull requests related to marker storage or retrieval

  
template-space
Issues or pull requests related to template spaces

  
triage
New issues waiting to be reviewed

  
wontfix
This will not be worked on

No labels
CRITICAL
Stale
WIP
bug
concept
coordinate
dataset
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
maintenance
maps
marker
mask
on hold
parcellation
preprocess
question
ready
storage
template-space
triage
wontfix
Milestone
Clear milestone
No items
No milestone
0.0.7 (alpha 6)
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!432
No description provided.