[BUG]: Cannot fetch Power2011 coordinates #431

Merged

synchon merged 2 commits from fix/power-coords into main

2025-03-04 14:11:02 +00:00

synchon commented

2025-03-04 06:25:45 +00:00

(Migrated from github.com)

Is there an existing issue for this?

I have searched the existing issues

Current Behavior

When trying to fetch Power2011 coordinates, I get a datalad error:

RuntimeError: Failed to get file from dataset: [{'action': 'get', 'path': '/home/fraimondo/junifer_data/v1/coordinates/Power2011/Power2011_MNI_VOIs.txt', 'status': 'impossible', 'refds': '/home/fraimondo/junifer_data/v1', 'message': 'path does not exist'}]

Indeed it seems that the issue comes from the name:

github.com/juaml/junifer@1b2072ef4e/junifer/data/coordinates/_coordinates.py (L279-L281)

It expects Power2011 as the name, but junifer-data has it as Power only.

Expected Behavior

I expect the Power 2011 coordinates to be loaded.

Steps To Reproduce

With junifer main branch.
Run

from junifer.data import get_data
get_data("coordinates", "Power2011", target_data=None)

Environment

junifer:
  version: 0.0.6.dev502
python:
  version: 3.12.7
  implementation: CPython
dependencies:
  click: 8.1.7
  numpy: 1.26.4
  scipy: 1.14.1
  datalad: 1.1.4
  pandas: 2.2.3
  nibabel: 5.3.2
  ruamel.yaml: 0.18.6
  looseversion: None
system:
  platform: Linux-6.12.9+bpo-amd64-x86_64-with-glibc2.36
environment:
  PATH: 
    /home/fraimondo/miniforge3/envs/junifer_dev/bin:/home/fraimondo/.local/bin:/home/fraimondo/miniforge3/condabin:/usr/local/bin:/home/fraimondo/miniforge3/condabin:/home/fraimondo/.cargo/bin:/usr/local/bin:/usr/bin:/bin:/usr/games

Relevant log output

Anything else?

No response

### Is there an existing issue for this? - [x] I have searched the existing issues ### Current Behavior When trying to fetch Power2011 coordinates, I get a datalad error: ``` RuntimeError: Failed to get file from dataset: [{'action': 'get', 'path': '/home/fraimondo/junifer_data/v1/coordinates/Power2011/Power2011_MNI_VOIs.txt', 'status': 'impossible', 'refds': '/home/fraimondo/junifer_data/v1', 'message': 'path does not exist'}] ``` Indeed it seems that the issue comes from the name: https://github.com/juaml/junifer/blob/1b2072ef4e6c08d1f84ea4f1ddc5aee079d3d84e/junifer/data/coordinates/_coordinates.py#L279-L281 It expects Power2011 as the `name`, but junifer-data has it as Power only. ### Expected Behavior I expect the Power 2011 coordinates to be loaded. ### Steps To Reproduce 1. With junifer main branch. 2. Run ``` Python from junifer.data import get_data get_data("coordinates", "Power2011", target_data=None) ``` ### Environment ```markdown junifer: version: 0.0.6.dev502 python: version: 3.12.7 implementation: CPython dependencies: click: 8.1.7 numpy: 1.26.4 scipy: 1.14.1 datalad: 1.1.4 pandas: 2.2.3 nibabel: 5.3.2 ruamel.yaml: 0.18.6 looseversion: None system: platform: Linux-6.12.9+bpo-amd64-x86_64-with-glibc2.36 environment: PATH: /home/fraimondo/miniforge3/envs/junifer_dev/bin:/home/fraimondo/.local/bin:/home/fraimondo/miniforge3/condabin:/usr/local/bin:/home/fraimondo/miniforge3/condabin:/home/fraimondo/.cargo/bin:/usr/local/bin:/usr/bin:/bin:/usr/games ``` ### Relevant log output ```shell ``` ### Anything else? _No response_

github-actions[bot] commented

2025-03-04 07:09:57 +00:00

(Migrated from github.com)

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-04 14:51 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.6.0 :---: Preview removed because the pull request was closed. 2025-03-04 14:51 UTC

codecov[bot] commented

2025-03-04 07:14:13 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (1b2072e) to head (4ad1a1f).
Report is 3 commits behind head on main.

❌ Your project status has failed because the head coverage (85.72%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         133      133           
  Lines        5656     5656           
  Branches      958      958           
=======================================
  Hits         4849     4849           
  Misses        618      618           
  Partials      189      189

Flag	Coverage Δ
junifer	`85.72% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
junifer/data/coordinates/_coordinates.py	`79.71% <ø> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/431?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 85.73%. Comparing base [(`1b2072e`)](https://app.codecov.io/gh/juaml/junifer/commit/1b2072ef4e6c08d1f84ea4f1ddc5aee079d3d84e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`4ad1a1f`)](https://app.codecov.io/gh/juaml/junifer/commit/4ad1a1f8d15f9ba61d9eee6cdb406f385aac6fe8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 3 commits behind head on main. :x: Your project status has failed because the head coverage (85.72%) is below the target coverage (90.00%). You can increase the head coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/431/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #431 +/- ## ======================================= Coverage 85.73% 85.73% ======================================= Files 133 133 Lines 5656 5656 Branches 958 958 ======================================= Hits 4849 4849 Misses 618 618 Partials 189 189 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/431/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/431/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `85.72% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/431?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/data/coordinates/\_coordinates.py](https://app.codecov.io/gh/juaml/junifer/pull/431?src=pr&el=tree&filepath=junifer%2Fdata%2Fcoordinates%2F_coordinates.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL2Nvb3JkaW5hdGVzL19jb29yZGluYXRlcy5weQ==) | `79.71% <ø> (ø)` | | </details>

fraimondo (Migrated from github.com) approved these changes

2025-03-04 14:04:35 +00:00