[BUG]: `fMRIPrepConfoundRemover` sets incorrect `t_r` due to `nilearn.image.clean_img` #420

Merged

synchon merged 3 commits from fix/fmriprepconfoundremover-tr into main

2025-01-24 09:39:23 +00:00

synchon commented

2025-01-22 18:07:08 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR fixes t_r tampering done by nilearn.image.clean_img in fMRIPrepConfoundRemover.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR fixes `t_r` tampering done by `nilearn.image.clean_img` in `fMRIPrepConfoundRemover`.

codecov[bot] commented

2025-01-22 18:29:08 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 0.01%. Comparing base (fd8cfc2) to head (2c96d4d).
Report is 4 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #420   +/-   ##
=====================================
  Coverage   0.01%   0.01%           
=====================================
  Files        133     133           
  Lines       5764    5764           
=====================================
  Hits           1       1           
  Misses      5763    5763

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../preprocess/confounds/fmriprep_confound_remover.py	`0.00% <ø> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/420?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 0.01%. Comparing base [(`fd8cfc2`)](https://app.codecov.io/gh/juaml/junifer/commit/fd8cfc23eed5c86d1b76e874b30ecbf1c0ca4da8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`2c96d4d`)](https://app.codecov.io/gh/juaml/junifer/commit/2c96d4d241c5462867566eef6637416fb813c8b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 4 commits behind head on main. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/420/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #420 +/- ## ===================================== Coverage 0.01% 0.01% ===================================== Files 133 133 Lines 5764 5764 ===================================== Hits 1 1 Misses 5763 5763 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/420/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/420/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/420?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [.../preprocess/confounds/fmriprep\_confound\_remover.py](https://app.codecov.io/gh/juaml/junifer/pull/420?src=pr&el=tree&filepath=junifer%2Fpreprocess%2Fconfounds%2Ffmriprep_confound_remover.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9wcmVwcm9jZXNzL2NvbmZvdW5kcy9mbXJpcHJlcF9jb25mb3VuZF9yZW1vdmVyLnB5) | `0.00% <ø> (ø)` | | </details>

fraimondo (Migrated from github.com) approved these changes

2025-01-24 09:00:12 +00:00