[ENH]: Rework parcellation logic #411

Merged

synchon merged 8 commits from refactor/parcellation-logic into main

2024-12-06 12:51:13 +00:00

synchon commented

2024-12-03 15:11:13 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR refactors the space transformation logic of parcellations to optimize warping at higher resolutions and joining in correct space. Follows very similar thought-process as in #395.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR refactors the space transformation logic of parcellations to optimize warping at higher resolutions and joining in correct space. Follows very similar thought-process as in #395.

codecov[bot] commented

2024-12-03 15:11:49 +00:00

(Migrated from github.com)

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 0.01%. Comparing base (ed5db99) to head (b86d632).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
junifer/data/parcellations/_parcellations.py	0.00%	14 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##            main    #411      +/-   ##
========================================
- Coverage   0.01%   0.01%   -0.01%     
========================================
  Files        133     133              
  Lines       5714    5719       +5     
========================================
  Hits           1       1              
- Misses      5713    5718       +5

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`0.00% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
junifer/data/parcellations/_parcellations.py	`0.00% <0.00%> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/411?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report Attention: Patch coverage is `0%` with `14 lines` in your changes missing coverage. Please review. > Project coverage is 0.01%. Comparing base [(`ed5db99`)](https://app.codecov.io/gh/juaml/junifer/commit/ed5db99dd180296f477475bfe495a2f051c0d02b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`b86d632`)](https://app.codecov.io/gh/juaml/junifer/commit/b86d6324151c3f00d591ba984502e33e640f5b9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 9 commits behind head on main. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/411?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Patch % | Lines | |---|---|---| | [junifer/data/parcellations/\_parcellations.py](https://app.codecov.io/gh/juaml/junifer/pull/411?src=pr&el=tree&filepath=junifer%2Fdata%2Fparcellations%2F_parcellations.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL3BhcmNlbGxhdGlvbnMvX3BhcmNlbGxhdGlvbnMucHk=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/juaml/junifer/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/411/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #411 +/- ## ======================================== - Coverage 0.01% 0.01% -0.01% ======================================== Files 133 133 Lines 5714 5719 +5 ======================================== Hits 1 1 - Misses 5713 5718 +5 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/411/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `0.00% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/411?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/data/parcellations/\_parcellations.py](https://app.codecov.io/gh/juaml/junifer/pull/411?src=pr&el=tree&filepath=junifer%2Fdata%2Fparcellations%2F_parcellations.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL3BhcmNlbGxhdGlvbnMvX3BhcmNlbGxhdGlvbnMucHk=) | `0.00% <0.00%> (ø)` | | </details>

github-actions[bot] commented

2024-12-03 15:27:41 +00:00

(Migrated from github.com)

PR Preview Action v1.4.8
🚀 Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-411/
on branch `gh-pages` at 2024-12-06 14:01 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.8 :---: :rocket: Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-411/ on branch [`gh-pages`](https://github.com/juaml/junifer/tree/gh-pages) at 2024-12-06 14:01 UTC