[BUG]: Fix metadata update for `MultipleDataGrabber` #398

Merged

synchon merged 7 commits from fix/multiple-dg-meta-update into main

2024-11-21 13:14:10 +00:00

synchon commented

2024-11-19 16:18:45 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR fixes metadata update for MultipleDataGrabber and refactors PatternDataGrabber.get_elements() to check list-like data type values.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR fixes metadata update for `MultipleDataGrabber` and refactors `PatternDataGrabber.get_elements()` to check list-like data type values.

codecov[bot] commented

2024-11-19 16:19:22 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (3a05a93) to head (92bbd72).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   87.10%   87.07%   -0.04%     
==========================================
  Files         129      129              
  Lines        4995     4966      -29     
  Branches      827      817      -10     
==========================================
- Hits         4351     4324      -27     
  Misses        474      474              
+ Partials      170      168       -2

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
junifer/datagrabber/multiple.py	`89.79% <ø> (-0.41%)`	⬇️
junifer/datagrabber/pattern.py	`97.40% <ø> (+1.24%)`	⬆️
junifer/datagrabber/pattern_validation_mixin.py	`97.72% <ø> (ø)`

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/398?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 87.07%. Comparing base [(`3a05a93`)](https://app.codecov.io/gh/juaml/junifer/commit/3a05a93e06e62b24260b3d176c3403b3d8bc93e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`92bbd72`)](https://app.codecov.io/gh/juaml/junifer/commit/92bbd72c2d960e490071884fb177ea0a328196e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 8 commits behind head on main. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/398/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/398?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #398 +/- ## ========================================== - Coverage 87.10% 87.07% -0.04% ========================================== Files 129 129 Lines 4995 4966 -29 Branches 827 817 -10 ========================================== - Hits 4351 4324 -27 Misses 474 474 + Partials 170 168 -2 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/398/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/398/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/398?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/datagrabber/multiple.py](https://app.codecov.io/gh/juaml/junifer/pull/398?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Fmultiple.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9tdWx0aXBsZS5weQ==) | `89.79% <ø> (-0.41%)` | :arrow_down: | | [junifer/datagrabber/pattern.py](https://app.codecov.io/gh/juaml/junifer/pull/398?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Fpattern.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9wYXR0ZXJuLnB5) | `97.40% <ø> (+1.24%)` | :arrow_up: | | [junifer/datagrabber/pattern\_validation\_mixin.py](https://app.codecov.io/gh/juaml/junifer/pull/398?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Fpattern_validation_mixin.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9wYXR0ZXJuX3ZhbGlkYXRpb25fbWl4aW4ucHk=) | `97.72% <ø> (ø)` | | </details> ---- 🚨 Try these New Features: - [Flaky Tests Detection](https://docs.codecov.com/docs/test-result-ingestion-beta) - Detect and resolve failed and flaky tests

github-actions[bot] commented

2024-11-19 16:34:21 +00:00

(Migrated from github.com)

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-21 13:26 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.8 :---: Preview removed because the pull request was closed. 2024-11-21 13:26 UTC

fraimondo (Migrated from github.com) approved these changes

2024-11-21 11:58:12 +00:00