juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

[BUG]: External dependencies not found despite being there #385

Merged
synchon merged 2 commits from fix/ants-ext-deps-check into main 2024-12-02 12:19:34 +00:00
Conversation 3 Commits 2 Files changed 2 +2 -1
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changes/newsfragments/385.bugfix Normal file
View file

@ -0,0 +1 @@
Use correct return code for ANTs commands while checking presence of external commands by `Synchon Mandal`_

2
junifer/pipeline/utils.py
View file

@ -237,7 +237,7 @@ def _check_ants(commands: Optional[list[str]] = None) -> bool:
shell=True, # is unsafe but kept for resolution via PATH shell=True, # is unsafe but kept for resolution via PATH
check=False, check=False,
) )
command_found = command_process.returncode == 0 command_found = command_process.returncode == 1
commands_found_results[command] = ( commands_found_results[command] = (
"found" if command_found else "not found" "found" if command_found else "not found"
) )