From 9be1f8a337c101d18e1aed05048c293fa132bb11 Mon Sep 17 00:00:00 2001 From: Synchon Mandal Date: Mon, 2 Dec 2024 12:19:40 +0100 Subject: [PATCH 1/2] fix: correct return code for ants commands in pipeline.utils --- junifer/pipeline/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/junifer/pipeline/utils.py b/junifer/pipeline/utils.py index f50188156..f8d66f90a 100644 --- a/junifer/pipeline/utils.py +++ b/junifer/pipeline/utils.py @@ -237,7 +237,7 @@ def _check_ants(commands: Optional[list[str]] = None) -> bool: shell=True, # is unsafe but kept for resolution via PATH check=False, ) - command_found = command_process.returncode == 0 + command_found = command_process.returncode == 1 commands_found_results[command] = ( "found" if command_found else "not found" ) -- 2.52.0 From b58fb9152bc8546c4556018c308512616a6d2997 Mon Sep 17 00:00:00 2001 From: Synchon Mandal Date: Mon, 2 Dec 2024 12:22:23 +0100 Subject: [PATCH 2/2] chore: add changelog 385.bugfix --- docs/changes/newsfragments/385.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/changes/newsfragments/385.bugfix diff --git a/docs/changes/newsfragments/385.bugfix b/docs/changes/newsfragments/385.bugfix new file mode 100644 index 000000000..b30a4d6f8 --- /dev/null +++ b/docs/changes/newsfragments/385.bugfix @@ -0,0 +1 @@ +Use correct return code for ANTs commands while checking presence of external commands by `Synchon Mandal`_ -- 2.52.0