juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

[CI]: Adopt custom CI image for junifer docs #374

Merged
synchon merged 22 commits from chore/docs-ci-image-upgrade into main 2024-10-14 11:59:29 +00:00
Conversation 5 Commits 22 Files changed 3 +43 -52
synchon commented 2024-10-11 07:54:01 +00:00 (Migrated from github.com)
Copy link
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR adopts custom CI image for building junifer docs and docs preview.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR adopts custom CI image for building junifer docs and docs preview.
github-actions[bot] commented 2024-10-11 16:18:01 +00:00 (Migrated from github.com)
Copy link
PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-14 12:13 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-14 12:13 UTC <!-- Sticky Pull Request Commentpr-preview -->
codecov[bot] commented 2024-10-14 08:03:43 +00:00 (Migrated from github.com)
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (88aa7a9) to head (e816c55).
Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #374   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          93       93           
  Lines        5066     5066           
  Branches     1031     1031           
=======================================
  Hits         4474     4474           
  Misses        426      426           
  Partials      166      166
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/374?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 88.31%. Comparing base [(`88aa7a9`)](https://app.codecov.io/gh/juaml/junifer/commit/88aa7a92b8563037af9b7af49a2391e02dcbf790?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`e816c55`)](https://app.codecov.io/gh/juaml/junifer/commit/e816c55bfb0d740263172ae4f567943f35583207?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 23 commits behind head on main. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/374/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #374 +/- ## ======================================= Coverage 88.31% 88.31% ======================================= Files 93 93 Lines 5066 5066 Branches 1031 1031 ======================================= Hits 4474 4474 Misses 426 426 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/374/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/374/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. </details>
fraimondo (Migrated from github.com) reviewed 2024-10-14 08:09:55 +00:00
.github/workflows/docs-preview.yml
@ -22,0 +27,4 @@
- name: Install system dependencies
run: |
# actions/checkout fails to identify Git as it's not in the CI image
apt-get -qq update && \
fraimondo (Migrated from github.com) commented 2024-10-14 08:09:50 +00:00
Copy link

Why can't we have this already in the image? Same as the "home dir" steps. Ideally, this image should be also usable externally.

Why can't we have this already in the image? Same as the "home dir" steps. Ideally, this image should be also usable externally.
synchon (Migrated from github.com) reviewed 2024-10-14 08:12:32 +00:00
.github/workflows/docs-preview.yml
@ -22,0 +27,4 @@
- name: Install system dependencies
run: |
# actions/checkout fails to identify Git as it's not in the CI image
apt-get -qq update && \
synchon (Migrated from github.com) commented 2024-10-14 08:12:32 +00:00
Copy link

Currently I couldn't find a way to put it inside the image as the build kept failing. I wanted the same as well so it's usable, but I guess it'll take some trial and error to fix this mess that gh-action has. Here's that PR: https://github.com/juaml/junifer/pull/373

Currently I couldn't find a way to put it inside the image as the build kept failing. I wanted the same as well so it's usable, but I guess it'll take some trial and error to fix this mess that gh-action has. Here's that PR: https://github.com/juaml/junifer/pull/373
fraimondo (Migrated from github.com) approved these changes 2024-10-14 08:16:22 +00:00
.github/workflows/docs-preview.yml
@ -22,0 +27,4 @@
- name: Install system dependencies
run: |
# actions/checkout fails to identify Git as it's not in the CI image
apt-get -qq update && \
fraimondo (Migrated from github.com) commented 2024-10-14 08:16:18 +00:00
Copy link

ok then, let's move forward.

ok then, let's move forward.
Sign in to join this conversation.
Reviewers
No reviewers
fraimondo
Labels
Clear labels   
CRITICAL
High Priority Issue

  
Stale

   
WIP
Work in progress

  
bug
Something isn't working

  
concept
Design/Implementation concepts

  
coordinate
Issues or pull requests related to coordinates (ROIs)

  
dataset
Issues or pull requests related to datagrabbers or datasets

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
maintenance
Issues or pull requests related to maintenance

  
maps
Issues or pull requests related to maps (probabilistic atlases)

  
marker
Issues or pull requests related to markers

  
mask
Issues or pull requests related to masks

  
on hold
Issue waiting on other issue(s)

  
parcellation
Issues or pull requests related to parcellations (deterministic atlases)

  
preprocess
Issues or pull requests related to preprocessors

  
question
Further information is requested

  
ready
Pull request is ready for review and merge

  
storage
Issues or pull requests related to marker storage or retrieval

  
template-space
Issues or pull requests related to template spaces

  
triage
New issues waiting to be reviewed

  
wontfix
This will not be worked on

No labels
CRITICAL
Stale
WIP
bug
concept
coordinate
dataset
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
maintenance
maps
marker
mask
on hold
parcellation
preprocess
question
ready
storage
template-space
triage
wontfix
Milestone
Clear milestone
No items
No milestone
0.0.6 (alpha 5)
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!374
No description provided.