Add `emomatching` task to AOMIC PIOP2 datagrabber #371

Merged

LeSasse merged 5 commits from fix/piop2_tasks into main

2024-10-07 10:18:15 +00:00

LeSasse commented

2024-10-01 09:01:45 +00:00

(Migrated from github.com)

fix #370
description of feature/fix
tests added/passed
add an entry for the latest changes

* [x] fix #370 * [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes

codecov[bot] commented

2024-10-01 09:02:46 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (ab4f391) to head (8087653).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          93       93           
  Lines        5067     5067           
  Branches     1031     1031           
=======================================
  Hits         4475     4475           
  Misses        426      426           
  Partials      166      166

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
junifer/datagrabber/aomic/piop2.py	`87.17% <ø> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/371?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 88.31%. Comparing base [(`ab4f391`)](https://app.codecov.io/gh/juaml/junifer/commit/ab4f391682412c1e5cc521de81bef46935f847c4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`8087653`)](https://app.codecov.io/gh/juaml/junifer/commit/8087653570d723741ac729b237f917b15b9d5863?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 6 commits behind head on main. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/371/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #371 +/- ## ======================================= Coverage 88.31% 88.31% ======================================= Files 93 93 Lines 5067 5067 Branches 1031 1031 ======================================= Hits 4475 4475 Misses 426 426 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/371/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/371?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/datagrabber/aomic/piop2.py](https://app.codecov.io/gh/juaml/junifer/pull/371?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Faomic%2Fpiop2.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9hb21pYy9waW9wMi5weQ==) | `87.17% <ø> (ø)` | | </details>

fraimondo (Migrated from github.com) requested changes

2024-10-01 09:19:52 +00:00

docs/whats_new.rst

This should now be in the docs/changes/newsfragments directory, in a file named 370.bugfix that has the following content:

Add ``'emomatching'`` task to :class:`DataladAOMICPIOP2` by `Leonard Sasse`_

This should now be in the `docs/changes/newsfragments` directory, in a file named 370.bugfix that has the following content: ``` Add ``'emomatching'`` task to :class:`DataladAOMICPIOP2` by `Leonard Sasse`_ ```

LeSasse (Migrated from github.com) reviewed

2024-10-01 09:46:11 +00:00

docs/whats_new.rst

i see

fraimondo (Migrated from github.com) approved these changes

2024-10-01 09:55:06 +00:00

github-actions[bot] commented

2024-10-07 10:13:49 +00:00

(Migrated from github.com)

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-07 10:37 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-07 10:37 UTC