[ENH]: Use datalad human-template-xfms dataset for junifer.data.get_xfm() #368

Merged
synchon merged 2 commits from update/get-xfm-src into main 2024-10-10 16:13:03 +00:00
synchon commented 2024-09-30 11:04:27 +00:00 (Migrated from github.com)
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR replaces the use of bulky human-template-xfm repo https://gin.g-node.org/juaml/human-template-xfms on Gin with a datalad-enabled one https://github.com/juaml/human-template-xfms on GitHub while still retaining the data hosting on Gin. This should speed-up file fetching and leverage the fantastic git-annex.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR replaces the use of bulky human-template-xfm repo https://gin.g-node.org/juaml/human-template-xfms on Gin with a datalad-enabled one https://github.com/juaml/human-template-xfms on GitHub while still retaining the data hosting on Gin. This should speed-up file fetching and leverage the fantastic `git-annex`.
github-actions[bot] commented 2024-09-30 11:34:22 +00:00 (Migrated from github.com)
PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-10 16:47 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.8 :---: Preview removed because the pull request was closed. 2024-10-10 16:47 UTC <!-- Sticky Pull Request Commentpr-preview -->
codecov[bot] commented 2024-10-07 10:22:27 +00:00 (Migrated from github.com)

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (fc4db76) to head (7032574).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   88.31%   88.31%   -0.01%     
==========================================
  Files          93       93              
  Lines        5067     5066       -1     
  Branches     1031     1031              
==========================================
- Hits         4475     4474       -1     
  Misses        426      426              
  Partials      166      166              
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/data/template_spaces.py 92.30% <ø> (-0.20%) ⬇️
## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/368?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 88.31%. Comparing base [(`fc4db76`)](https://app.codecov.io/gh/juaml/junifer/commit/fc4db76f7e97cde1a74f74ed386c83ab335f95ee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`7032574`)](https://app.codecov.io/gh/juaml/junifer/commit/70325744ba07ce36684209a010a10d89e68f85a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). > Report is 3 commits behind head on main. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/368/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #368 +/- ## ========================================== - Coverage 88.31% 88.31% -0.01% ========================================== Files 93 93 Lines 5067 5066 -1 Branches 1031 1031 ========================================== - Hits 4475 4474 -1 Misses 426 426 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/368/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/junifer/pull/368?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/data/template\_spaces.py](https://app.codecov.io/gh/juaml/junifer/pull/368?src=pr&el=tree&filepath=junifer%2Fdata%2Ftemplate_spaces.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL3RlbXBsYXRlX3NwYWNlcy5weQ==) | `92.30% <ø> (-0.20%)` | :arrow_down: | </details>
fraimondo (Migrated from github.com) approved these changes 2024-10-10 15:34:02 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!368
No description provided.