[FIX]: Enable `spike` for `fMRIPrepConfoundRemover` #360

Merged

synchon merged 3 commits from fix/fmriprep-confound-remover-spike into main

2024-08-14 13:12:22 +00:00

synchon commented

2024-08-14 12:15:41 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR fixes the spike mapping from adhoc to fmriprep's "framewise_displacement" by including it in the validation.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR fixes the `spike` mapping from `adhoc` to `fmriprep`'s `"framewise_displacement"` by including it in the validation.

codecov[bot] commented

2024-08-14 12:21:18 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (73cd8a3) to head (23bdc08).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files         115      115           
  Lines        5175     5175           
  Branches     1032     1032           
=======================================
  Hits         4583     4583           
  Misses        426      426           
  Partials      166      166

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../preprocess/confounds/fmriprep_confound_remover.py	`99.34% <ø> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/360?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 88.56%. Comparing base [(`73cd8a3`)](https://app.codecov.io/gh/juaml/junifer/commit/73cd8a359f624e12e71afd6a78d708ae99bb0c10?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`23bdc08`)](https://app.codecov.io/gh/juaml/junifer/commit/23bdc089cabfff24b99d9dc7183f3f86a2206638?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/360/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/360?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #360 +/- ## ======================================= Coverage 88.56% 88.56% ======================================= Files 115 115 Lines 5175 5175 Branches 1032 1032 ======================================= Hits 4583 4583 Misses 426 426 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/360/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/360?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [.../preprocess/confounds/fmriprep\_confound\_remover.py](https://app.codecov.io/gh/juaml/junifer/pull/360?src=pr&el=tree&filepath=junifer%2Fpreprocess%2Fconfounds%2Ffmriprep_confound_remover.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9wcmVwcm9jZXNzL2NvbmZvdW5kcy9mbXJpcHJlcF9jb25mb3VuZF9yZW1vdmVyLnB5) | `99.34% <ø> (ø)` | | </details>

LeSasse (Migrated from github.com) approved these changes

2024-08-14 12:33:46 +00:00

LeSasse (Migrated from github.com) left a comment

I see no issue with this.

github-actions[bot] commented

2024-08-14 12:39:23 +00:00

(Migrated from github.com)

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-14 13:29 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.7 :---: Preview removed because the pull request was closed. 2024-08-14 13:29 UTC