[ENH]: Adapt `MultipleDataGrabber` to `patterns` with nested data types #351

Merged

synchon merged 20 commits from fix/multiple-dg-access into main

2024-07-19 11:15:25 +00:00

synchon commented

2024-07-12 05:32:12 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR refactors MultipleDataGrabber to adapt it to updated DataGrabber patterns with nested data types.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR refactors `MultipleDataGrabber` to adapt it to updated DataGrabber `patterns` with nested data types.

github-actions[bot] commented

2024-07-12 05:52:21 +00:00

(Migrated from github.com)

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-19 11:32 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.7 :---: Preview removed because the pull request was closed. 2024-07-19 11:32 UTC

codecov[bot] commented

2024-07-12 06:11:37 +00:00

(Migrated from github.com)

Attention: Patch coverage is 89.65517% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.56%. Comparing base (e016a7d) to head (f2d8d08).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   88.67%   88.56%   -0.11%     
==========================================
  Files         115      115              
  Lines        5138     5178      +40     
  Branches     1019     1034      +15     
==========================================
+ Hits         4556     4586      +30     
- Misses        422      426       +4     
- Partials      160      166       +6

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`88.56% <89.65%> (-0.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
junifer/datagrabber/__init__.py	`100.00% <100.00%> (ø)`
junifer/datagrabber/hcp1200/hcp1200.py	`100.00% <100.00%> (ø)`
junifer/utils/__init__.py	`100.00% <100.00%> (ø)`
junifer/utils/helpers.py	`100.00% <100.00%> (ø)`
junifer/utils/logging.py	`73.58% <100.00%> (+1.58%)`	⬆️
junifer/datagrabber/pattern.py	`96.69% <83.33%> (-1.56%)`	⬇️
junifer/datagrabber/pattern_validation_mixin.py	`96.96% <96.96%> (ø)`
junifer/datagrabber/base.py	`91.80% <0.00%> (-6.51%)`	⬇️
junifer/datagrabber/multiple.py	`91.37% <73.33%> (-6.50%)`	⬇️

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/351?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report Attention: Patch coverage is `89.65517%` with `12 lines` in your changes missing coverage. Please review. > Project coverage is 88.56%. Comparing base [(`e016a7d`)](https://app.codecov.io/gh/juaml/junifer/commit/e016a7d6e7a1b104b6b1204a3356252d5ab7471c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`f2d8d08`)](https://app.codecov.io/gh/juaml/junifer/commit/f2d8d08984f3a47c67e18db24c6ab6b3e82b3c77?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/351/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #351 +/- ## ========================================== - Coverage 88.67% 88.56% -0.11% ========================================== Files 115 115 Lines 5138 5178 +40 Branches 1019 1034 +15 ========================================== + Hits 4556 4586 +30 - Misses 422 426 +4 - Partials 160 166 +6 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/351/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `88.56% <89.65%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/351?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/datagrabber/\_\_init\_\_.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [junifer/datagrabber/hcp1200/hcp1200.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Fhcp1200%2Fhcp1200.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9oY3AxMjAwL2hjcDEyMDAucHk=) | `100.00% <100.00%> (ø)` | | | [junifer/utils/\_\_init\_\_.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Futils%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci91dGlscy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [junifer/utils/helpers.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Futils%2Fhelpers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci91dGlscy9oZWxwZXJzLnB5) | `100.00% <100.00%> (ø)` | | | [junifer/utils/logging.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Futils%2Flogging.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci91dGlscy9sb2dnaW5nLnB5) | `73.58% <100.00%> (+1.58%)` | :arrow_up: | | [junifer/datagrabber/pattern.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Fpattern.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9wYXR0ZXJuLnB5) | `96.69% <83.33%> (-1.56%)` | :arrow_down: | | [junifer/datagrabber/pattern\_validation\_mixin.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Fpattern_validation_mixin.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9wYXR0ZXJuX3ZhbGlkYXRpb25fbWl4aW4ucHk=) | `96.96% <96.96%> (ø)` | | | [junifer/datagrabber/base.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9iYXNlLnB5) | `91.80% <0.00%> (-6.51%)` | :arrow_down: | | [junifer/datagrabber/multiple.py](https://app.codecov.io/gh/juaml/junifer/pull/351?src=pr&el=tree&filepath=junifer%2Fdatagrabber%2Fmultiple.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9tdWx0aXBsZS5weQ==) | `91.37% <73.33%> (-6.50%)` | :arrow_down: | </details>

fraimondo (Migrated from github.com) approved these changes

2024-07-19 11:15:14 +00:00