[BUG]: Extra dimension added to mask after warping via ANTs #340

Merged

synchon merged 2 commits from fix/mask-warp-incorrect-ndim into main

2024-05-07 08:30:47 +00:00

synchon commented

2024-05-06 16:00:22 +00:00

(Migrated from github.com)

This PR fixes extra dimension addition to mask after warping via ANTs.

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR fixes extra dimension addition to mask after warping via ANTs. * [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes

codecov[bot] commented

2024-05-06 16:03:15 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e0cb0f2) to head (ea404d2).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #340   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/340?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 100.00%. Comparing base [(`e0cb0f2`)](https://app.codecov.io/gh/juaml/junifer/commit/e0cb0f233b071bb9e15818cabef036f7bd6695f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`ea404d2`)](https://app.codecov.io/gh/juaml/junifer/pull/340?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/340/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #340 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 1 1 ========================================= Hits 1 1 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/340/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. </details>

synchon commented

2024-05-06 16:03:40 +00:00

(Migrated from github.com)

@fraimondo Can you check if this PR solves your mask warping issue if YAML from #339 is run?

github-actions[bot] commented

2024-05-06 16:22:40 +00:00

(Migrated from github.com)

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-07 08:49 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.7 :---: Preview removed because the pull request was closed. 2024-05-07 08:49 UTC

fraimondo (Migrated from github.com) approved these changes

2024-05-06 19:39:52 +00:00

fraimondo commented

2024-05-06 19:40:18 +00:00

(Migrated from github.com)

@fraimondo Can you check if this PR solves your mask warping issue if YAML from #339 is run?

yes, it works now. I pulled from #339 and #340 and the YAML ran without issues.

> @fraimondo Can you check if this PR solves your mask warping issue if YAML from #339 is run? yes, it works now. I pulled from #339 and #340 and the YAML ran without issues.

fraimondo commented

2024-05-06 19:40:37 +00:00

(Migrated from github.com)

Misclicked the close button