[FIX]: Element parsing for HTCondor via `VARS` #312

Merged

synchon merged 4 commits from fix/condor-element-parse into main

2024-03-19 13:23:47 +00:00

synchon commented

2024-03-19 12:26:01 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR fixes the script generation of HTCondorAdapter to allow proper parsing of HTCondor's VARS. In particular, replaces single quote with double quotes for element parsing.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR fixes the script generation of `HTCondorAdapter` to allow proper parsing of HTCondor's `VARS`. In particular, replaces single quote with double quotes for element parsing.

codecov[bot] commented

2024-03-19 12:29:47 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (0ac5a58) to head (dc704ac).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files         105      105           
  Lines        4622     4622           
  Branches      935      935           
=======================================
  Hits         4093     4093           
  Misses        379      379           
  Partials      150      150

Flag	Coverage Δ
junifer	`88.55% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
junifer/api/queue_context/htcondor_adapter.py	`99.10% <ø> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/312?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 88.55%. Comparing base [(`0ac5a58`)](https://app.codecov.io/gh/juaml/junifer/commit/0ac5a5889ddefed0e94af9e2da05c7ddbd255ad8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`dc704ac`)](https://app.codecov.io/gh/juaml/junifer/pull/312?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/312/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #312 +/- ## ======================================= Coverage 88.55% 88.55% ======================================= Files 105 105 Lines 4622 4622 Branches 935 935 ======================================= Hits 4093 4093 Misses 379 379 Partials 150 150 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/312/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `88.55% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/312?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/api/queue\_context/htcondor\_adapter.py](https://app.codecov.io/gh/juaml/junifer/pull/312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvcXVldWVfY29udGV4dC9odGNvbmRvcl9hZGFwdGVyLnB5) | `99.10% <ø> (ø)` | | </details>

LeSasse (Migrated from github.com) approved these changes

2024-03-19 12:30:41 +00:00

LeSasse (Migrated from github.com) left a comment

LGTM

github-actions[bot] commented

2024-03-19 12:33:58 +00:00

(Migrated from github.com)

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-19 13:28 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.7 :---: Preview removed because the pull request was closed. 2024-03-19 13:28 UTC