[BUG]: Fix interpolation scheme for native parcellation and mask #276

Merged

synchon merged 3 commits from fix/interp-parcel-mask into main

2023-11-17 15:05:50 +00:00

synchon commented

2023-11-17 13:22:56 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR fixes the interpolation scheme for parcellation and mask transformation to native space, to nearest neighbour instead of spline.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR fixes the interpolation scheme for parcellation and mask transformation to native space, to nearest neighbour instead of spline.

github-actions[bot] commented

2023-11-17 13:28:39 +00:00

(Migrated from github.com)

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-17 15:09 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.4 :---: Preview removed because the pull request was closed. 2023-11-17 15:09 UTC

codecov[bot] commented

2023-11-17 13:29:44 +00:00

(Migrated from github.com)

Codecov Report

Merging #276 (422f72c) into main (df4cee7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          99       99           
  Lines        4371     4371           
  Branches      842      842           
=======================================
  Hits         3926     3926           
  Misses        305      305           
  Partials      140      140

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`89.81% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
junifer/data/masks.py	`82.73% <ø> (ø)`
junifer/data/parcellations.py	`88.59% <ø> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#276](https://app.codecov.io/gh/juaml/junifer/pull/276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (422f72c) into [main](https://app.codecov.io/gh/juaml/junifer/commit/df4cee720fa3ebf46630ce2f8eacef39c84d17fa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (df4cee7) will **not change** coverage. > The diff coverage is `n/a`. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/276/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #276 +/- ## ======================================= Coverage 89.81% 89.81% ======================================= Files 99 99 Lines 4371 4371 Branches 842 842 ======================================= Hits 3926 3926 Misses 305 305 Partials 140 140 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/276/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `89.81% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/data/masks.py](https://app.codecov.io/gh/juaml/junifer/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL21hc2tzLnB5) | `82.73% <ø> (ø)` | | | [junifer/data/parcellations.py](https://app.codecov.io/gh/juaml/junifer/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL3BhcmNlbGxhdGlvbnMucHk=) | `88.59% <ø> (ø)` | | </details>

fraimondo (Migrated from github.com) approved these changes

2023-11-17 15:04:35 +00:00