[FIX]: Make native warped components persist #274

Merged

synchon merged 5 commits from fix/nibabel-cache-bypass into main

2023-11-07 14:47:03 +00:00

synchon commented

2023-11-07 13:26:38 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR makes native warped components (parcellations, coordinates and masks) persist after the warping is complete via element-scoped tempdirs and tempfiles. This is needed due to nibabel and numpy caching file paths for computation later.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR makes native warped components (parcellations, coordinates and masks) persist after the warping is complete via element-scoped tempdirs and tempfiles. This is needed due to nibabel and numpy caching file paths for computation later.

codecov[bot] commented

2023-11-07 13:29:48 +00:00

(Migrated from github.com)

Codecov Report

Merging #274 (c507cfc) into main (124c175) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   90.08%   90.04%   -0.05%     
==========================================
  Files          90       90              
  Lines        4116     4118       +2     
  Branches      811      811              
==========================================
  Hits         3708     3708              
- Misses        284      286       +2     
  Partials      124      124

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`90.04% <0.00%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
junifer/preprocess/fsl/bold_warper.py	`72.72% <ø> (ø)`
junifer/data/coordinates.py	`70.76% <0.00%> (ø)`
junifer/data/masks.py	`82.73% <0.00%> (-0.60%)`	⬇️
junifer/data/parcellations.py	`88.59% <0.00%> (-0.20%)`	⬇️

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#274](https://app.codecov.io/gh/juaml/junifer/pull/274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (c507cfc) into [main](https://app.codecov.io/gh/juaml/junifer/commit/124c1759b7ee86d251bc561ad243f66eee5ba81f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (124c175) will **decrease** coverage by `0.05%`. > The diff coverage is `0.00%`. [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/274/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #274 +/- ## ========================================== - Coverage 90.08% 90.04% -0.05% ========================================== Files 90 90 Lines 4116 4118 +2 Branches 811 811 ========================================== Hits 3708 3708 - Misses 284 286 +2 Partials 124 124 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/274/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `90.04% <0.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/preprocess/fsl/bold\_warper.py](https://app.codecov.io/gh/juaml/junifer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9wcmVwcm9jZXNzL2ZzbC9ib2xkX3dhcnBlci5weQ==) | `72.72% <ø> (ø)` | | | [junifer/data/coordinates.py](https://app.codecov.io/gh/juaml/junifer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL2Nvb3JkaW5hdGVzLnB5) | `70.76% <0.00%> (ø)` | | | [junifer/data/masks.py](https://app.codecov.io/gh/juaml/junifer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL21hc2tzLnB5) | `82.73% <0.00%> (-0.60%)` | :arrow_down: | | [junifer/data/parcellations.py](https://app.codecov.io/gh/juaml/junifer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL3BhcmNlbGxhdGlvbnMucHk=) | `88.59% <0.00%> (-0.20%)` | :arrow_down: |

github-actions[bot] commented

2023-11-07 13:32:38 +00:00

(Migrated from github.com)

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-07 14:51 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.4 :---: Preview removed because the pull request was closed. 2023-11-07 14:51 UTC

fraimondo (Migrated from github.com) approved these changes

2023-11-07 14:28:22 +00:00