[ENH]: Improve `BasePreprocessor` and `fMRIPrepConfoundRemover` #260

Merged

synchon merged 10 commits from update/preprocessor-base into main

2023-10-18 09:37:06 +00:00

synchon commented

2023-10-17 10:21:04 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR refactors internals of BasePreprocessor to make it easy for subclassing. It also adapts fMRIPrepConfoundRemover to base class changes.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR refactors internals of `BasePreprocessor` to make it easy for subclassing. It also adapts `fMRIPrepConfoundRemover` to base class changes.

codecov[bot] commented

2023-10-17 10:25:55 +00:00

(Migrated from github.com)

Codecov Report

Merging #260 (407978c) into main (b0f3714) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   92.83%   92.82%   -0.02%     
==========================================
  Files          86       86              
  Lines        3811     3790      -21     
  Branches      744      741       -3     
==========================================
- Hits         3538     3518      -20     
+ Misses        170      169       -1     
  Partials      103      103

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
junifer/preprocess/base.py	`84.61% <ø> (+0.17%)`	⬆️
.../preprocess/confounds/fmriprep_confound_remover.py	`98.70% <ø> (-0.12%)`	⬇️

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/260?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#260](https://app.codecov.io/gh/juaml/junifer/pull/260?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (407978c) into [main](https://app.codecov.io/gh/juaml/junifer/commit/b0f3714809043465603502963e84356187271f43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (b0f3714) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/260/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #260 +/- ## ========================================== - Coverage 92.83% 92.82% -0.02% ========================================== Files 86 86 Lines 3811 3790 -21 Branches 744 741 -3 ========================================== - Hits 3538 3518 -20 + Misses 170 169 -1 Partials 103 103 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/260/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/260/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/preprocess/base.py](https://app.codecov.io/gh/juaml/junifer/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9wcmVwcm9jZXNzL2Jhc2UucHk=) | `84.61% <ø> (+0.17%)` | :arrow_up: | | [.../preprocess/confounds/fmriprep\_confound\_remover.py](https://app.codecov.io/gh/juaml/junifer/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9wcmVwcm9jZXNzL2NvbmZvdW5kcy9mbXJpcHJlcF9jb25mb3VuZF9yZW1vdmVyLnB5) | `98.70% <ø> (-0.12%)` | :arrow_down: |

github-actions[bot] commented

2023-10-17 10:27:48 +00:00

(Migrated from github.com)

PR Preview Action v1.4.4
🚀 Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-260/
on branch `gh-pages` at 2023-10-18 09:41 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.4 :---: :rocket: Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-260/ on branch [`gh-pages`](https://github.com/juaml/junifer/tree/gh-pages) at 2023-10-18 09:41 UTC

fraimondo (Migrated from github.com) approved these changes

2023-10-18 09:12:24 +00:00