[ENH]: Coordinates - Autobiographical Memory #250

Merged

synchon merged 3 commits from feat/autobiographical-memory-coords into main

2024-03-06 17:05:35 +00:00

synchon commented

2024-02-22 13:42:56 +00:00

(Migrated from github.com)

Are you requiring a new dataset or marker?

I understand this is not a marker or dataset request

Which feature do you want to include?

@jkroell asked if we can include the autobiographical memory coordinates from this paper:
https://direct.mit.edu/jocn/article-abstract/21/3/489/4656/The-Common-Neural-Basis-of-Autobiographical-Memory

The coordinates are found in Table 6. I believe Jean has them as text file as well.

How do you imagine this integrated in junifer?

As in-built coordinates.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

### Are you requiring a new dataset or marker? - [X] I understand this is not a marker or dataset request ### Which feature do you want to include? @jkroell asked if we can include the autobiographical memory coordinates from this paper: https://direct.mit.edu/jocn/article-abstract/21/3/489/4656/The-Common-Neural-Basis-of-Autobiographical-Memory The coordinates are found in Table 6. I believe [Jean](https://github.com/jkroell) has them as text file as well. ### How do you imagine this integrated in junifer? As in-built coordinates. ### Do you have a sample code that implements this outside of junifer? _No response_ ### Anything else to say? _No response_

github-actions[bot] commented

2024-02-22 13:50:01 +00:00

(Migrated from github.com)

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-06 17:10 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.7 :---: Preview removed because the pull request was closed. 2024-03-06 17:10 UTC

codecov[bot] commented

2024-02-22 14:11:14 +00:00

(Migrated from github.com)

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9316bca) 88.79% compared to head (a0e5c4b) 88.79%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         101      101           
  Lines        4506     4506           
  Branches      860      860           
=======================================
  Hits         4001     4001           
  Misses        366      366           
  Partials      139      139

Flag	Coverage Δ
junifer	`88.79% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
junifer/data/coordinates.py	`63.38% <ø> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/250?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`9316bca`)](https://app.codecov.io/gh/juaml/junifer/commit/9316bca0aa61c3f48946e0c235ea4286d2fd1a87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) 88.79% compared to head [(`a0e5c4b`)](https://app.codecov.io/gh/juaml/junifer/pull/250?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) 88.79%. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/250/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #250 +/- ## ======================================= Coverage 88.79% 88.79% ======================================= Files 101 101 Lines 4506 4506 Branches 860 860 ======================================= Hits 4001 4001 Misses 366 366 Partials 139 139 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `88.79% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/data/coordinates.py](https://app.codecov.io/gh/juaml/junifer/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL2Nvb3JkaW5hdGVzLnB5) | `63.38% <ø> (ø)` | | </details>

fraimondo (Migrated from github.com) approved these changes

2024-03-06 15:46:52 +00:00