[ENH]: Allow for using venv in queue kind #249
Labels
No labels
CRITICAL
Stale
WIP
bug
concept
coordinate
dataset
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
maintenance
maps
marker
mask
on hold
parcellation
preprocess
question
ready
storage
template-space
triage
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
juaml/junifer!249
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/run-venv"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Are you requiring a new dataset or marker?
Which feature do you want to include?
Some people do not like to use conda, it would be nice to be able to set the
envvariable to a path of an environment created using the venv tool to run a junifer pipeline.How do you imagine this integrated in junifer?
Similar to conda, but with venv.
Do you have a sample code that implements this outside of junifer?
No response
Anything else to say?
No response
You can ask @LeSasse how does he feel about this one too...
Overall, this PR is the real MVP. Just a few questions for clarification from my side.
@ -0,0 +1 @@Support ``venv`` as environment kind for queueing jobs by `Synchon Mandal`_nice!
@ -52,11 +52,13 @@ The following parameters are available for HTCondor:* ``kind``: This is the kind of virtual environment to use:no support for a relative path? What is the main rationale behind this?
@ -0,0 +1,22 @@#!/bin/bashhard coded shell? I suppose this will change in a separate PR?
the environment path in this case i suppose, might be worth mentioning here specifically
@ -52,11 +52,13 @@ The following parameters are available for HTCondor:* ``kind``: This is the kind of virtual environment to use:The main question is: relative to what? The YAML? the CWD? We had this issue in #224, #127, #191.
If we can answer this, then we can also use a relative path.
@ -0,0 +1,22 @@#!/bin/bashI think this is the case. We need to provide
run_venv.zsh,run_conda.zsh, etc.@ -52,11 +52,13 @@ The following parameters are available for HTCondor:* ``kind``: This is the kind of virtual environment to use:i agree. Absolute will keep it simple.
@ -0,0 +1,22 @@#!/bin/bash+1
@ -52,11 +52,13 @@ The following parameters are available for HTCondor:* ``kind``: This is the kind of virtual environment to use:I think relative paths are simpler, problem is always the same: determining the "relative to" to compute an absolute path and fix it in the yaml.
@ -0,0 +1,22 @@#!/bin/bashYes this will change in #273 which will require a new option in the YAML.
@ -52,11 +52,13 @@ The following parameters are available for HTCondor:* ``kind``: This is the kind of virtual environment to use:We have been following the "relative to YAML" idea and I updated it to reflect that.
@ -0,0 +1,22 @@#!/bin/bashUpdated it to make it clear.
LGTM, merge once tests pass I suppose.