[ENH]: Implement `junifer reset` to delete job/results file. #240

Merged

synchon merged 6 commits from feat/junifer-reset into main

2024-03-07 09:49:50 +00:00

synchon commented

2024-02-26 16:39:55 +00:00

(Migrated from github.com)

Are you requiring a new dataset or marker?

I understand this is not a marker or dataset request

Which feature do you want to include?

Sometimes I make a mistake with one parameter in the YAML. Then I need to go and check where the storage file points to, delete the directory and then finally run junifer queue with --overwrite.

I would like this process to be part of junifer.

How do you imagine this integrated in junifer?

junifer reset /path/to/yaml

This should delete the storage directory and the job directory.

Although the reset argument must not necessary be that one.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

### Are you requiring a new dataset or marker? - [X] I understand this is not a marker or dataset request ### Which feature do you want to include? Sometimes I make a mistake with one parameter in the YAML. Then I need to go and check where the storage file points to, delete the directory and then finally run `junifer queue` with `--overwrite`. I would like this process to be part of junifer. ### How do you imagine this integrated in junifer? `junifer reset /path/to/yaml` This should delete the storage directory and the job directory. Although the `reset` argument must not necessary be that one. ### Do you have a sample code that implements this outside of junifer? _No response_ ### Anything else to say? _No response_

github-actions[bot] commented

2024-02-26 16:48:28 +00:00

(Migrated from github.com)

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-07 09:54 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.7 :---: Preview removed because the pull request was closed. 2024-03-07 09:54 UTC

codecov[bot] commented

2024-02-26 17:09:49 +00:00

(Migrated from github.com)

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 88.91%. Comparing base (9316bca) to head (464b8bf).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   88.79%   88.91%   +0.12%     
==========================================
  Files         101      101              
  Lines        4506     4529      +23     
  Branches      860      864       +4     
==========================================
+ Hits         4001     4027      +26     
+ Misses        366      361       -5     
- Partials      139      141       +2

Flag	Coverage Δ
junifer	`88.91% <78.26%> (+0.12%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
junifer/api/cli.py	`79.64% <100.00%> (+9.16%)`	⬆️
junifer/pipeline/registry.py	`100.00% <ø> (ø)`
junifer/api/functions.py	`94.20% <66.66%> (-2.16%)`	⬇️

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/240?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report Attention: Patch coverage is `78.26087%` with `5 lines` in your changes are missing coverage. Please review. > Project coverage is 88.91%. Comparing base [(`9316bca`)](https://app.codecov.io/gh/juaml/junifer/commit/9316bca0aa61c3f48946e0c235ea4286d2fd1a87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`464b8bf`)](https://app.codecov.io/gh/juaml/junifer/pull/240?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/240/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #240 +/- ## ========================================== + Coverage 88.79% 88.91% +0.12% ========================================== Files 101 101 Lines 4506 4529 +23 Branches 860 864 +4 ========================================== + Hits 4001 4027 +26 + Misses 366 361 -5 - Partials 139 141 +2 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/240/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/240/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `88.91% <78.26%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/api/cli.py](https://app.codecov.io/gh/juaml/junifer/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvY2xpLnB5) | `79.64% <100.00%> (+9.16%)` | :arrow_up: | | [junifer/pipeline/registry.py](https://app.codecov.io/gh/juaml/junifer/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9waXBlbGluZS9yZWdpc3RyeS5weQ==) | `100.00% <ø> (ø)` | | | [junifer/api/functions.py](https://app.codecov.io/gh/juaml/junifer/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZnVuY3Rpb25zLnB5) | `94.20% <66.66%> (-2.16%)` | :arrow_down: | </details>

fraimondo (Migrated from github.com) approved these changes

2024-03-06 15:45:34 +00:00