chore: junifer.data.parcellations cleanup #238

Merged
synchon merged 8 commits from chore/parcellation-cleanup into main 2023-07-07 14:08:24 +00:00
synchon commented 2023-07-07 13:32:38 +00:00 (Migrated from github.com)
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR improves docstrings and code style and parametrizes remaining tests for junifer.data.parcellations.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR improves docstrings and code style and parametrizes remaining tests for `junifer.data.parcellations`.
codecov[bot] commented 2023-07-07 13:34:13 +00:00 (Migrated from github.com)

Codecov Report

Merging #238 (4fd281f) into main (765380f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   93.20%   93.12%   -0.08%     
==========================================
  Files          84       84              
  Lines        3692     3695       +3     
  Branches      709      709              
==========================================
  Hits         3441     3441              
- Misses        159      160       +1     
- Partials       92       94       +2     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 93.12% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
junifer/data/parcellations.py 91.75% <100.00%> (-0.70%) ⬇️
## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#238](https://app.codecov.io/gh/juaml/junifer/pull/238?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (4fd281f) into [main](https://app.codecov.io/gh/juaml/junifer/commit/765380fb58a924f1c6625f1cd4f28e56860e2e33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (765380f) will **decrease** coverage by `0.08%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/238/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #238 +/- ## ========================================== - Coverage 93.20% 93.12% -0.08% ========================================== Files 84 84 Lines 3692 3695 +3 Branches 709 709 ========================================== Hits 3441 3441 - Misses 159 160 +1 - Partials 92 94 +2 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.12% <100.00%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/juaml/junifer/pull/238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/data/parcellations.py](https://app.codecov.io/gh/juaml/junifer/pull/238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL3BhcmNlbGxhdGlvbnMucHk=) | `91.75% <100.00%> (-0.70%)` | :arrow_down: |
fraimondo (Migrated from github.com) approved these changes 2023-07-07 13:42:14 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!238
No description provided.