refactor: consistent use of `DataReader` #227

Merged

synchon merged 7 commits from chore/dr-cleanup into main

2023-06-20 10:28:05 +00:00

synchon commented

2023-05-16 13:49:16 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR removes datareader / DataReader naming convention issue in the codebase and adopts DataReader to make the code consistent with the docs.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR removes datareader / DataReader naming convention issue in the codebase and adopts DataReader to make the code consistent with the docs.

LeSasse (Migrated from github.com) reviewed

2023-05-16 13:49:16 +00:00

codecov[bot] commented

2023-05-16 13:50:08 +00:00

(Migrated from github.com)

Codecov Report

Merging #227 (ef739b5) into main (84ed73b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          80       80           
  Lines        3458     3458           
  Branches      650      650           
=======================================
  Hits         3237     3237           
  Misses        144      144           
  Partials       77       77

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`93.60% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/api/decorators.py	`100.00% <ø> (ø)`
junifer/datareader/default.py	`100.00% <ø> (ø)`
junifer/markers/collection.py	`100.00% <ø> (ø)`

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#227](https://app.codecov.io/gh/juaml/junifer/pull/227?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (ef739b5) into [main](https://app.codecov.io/gh/juaml/junifer/commit/84ed73b3c8e09734a53144ca7e8847faa3d6442f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (84ed73b) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/227/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #227 +/- ## ======================================= Coverage 93.60% 93.60% ======================================= Files 80 80 Lines 3458 3458 Branches 650 650 ======================================= Hits 3237 3237 Misses 144 144 Partials 77 77 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.60% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/juaml/junifer/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/api/decorators.py](https://app.codecov.io/gh/juaml/junifer/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZGVjb3JhdG9ycy5weQ==) | `100.00% <ø> (ø)` | | | [junifer/datareader/default.py](https://app.codecov.io/gh/juaml/junifer/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhcmVhZGVyL2RlZmF1bHQucHk=) | `100.00% <ø> (ø)` | | | [junifer/markers/collection.py](https://app.codecov.io/gh/juaml/junifer/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2NvbGxlY3Rpb24ucHk=) | `100.00% <ø> (ø)` | |

github-actions[bot] commented

2023-05-16 13:57:51 +00:00

(Migrated from github.com)

PR Preview Action v0.0.2-79-ge40ada5e
🚀 Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-227/
on branch `gh-pages` at 2023-05-16 14:16 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v0.0.2-79-ge40ada5e :---: :rocket: Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-227/ on branch [`gh-pages`](https://github.com/juaml/junifer/tree/gh-pages) at 2023-05-16 14:16 UTC

fraimondo (Migrated from github.com) approved these changes

2023-06-20 10:27:26 +00:00