juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

refactor: consistent use of DataGrabber #226

Merged
synchon merged 32 commits from chore/dg-cleanup into main 2023-06-20 10:27:52 +00:00
Conversation 4 Commits 32 Files changed 48 +442 -410
synchon commented 2023-05-16 12:33:44 +00:00 (Migrated from github.com)
Copy link
  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR removes datagrabber / DataGrabber naming convention issue in the codebase and adopts DataGrabber to make the code consistent with the docs.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR removes `datagrabber` / `DataGrabber` naming convention issue in the codebase and adopts `DataGrabber` to make the code consistent with the docs.
LeSasse (Migrated from github.com) reviewed 2023-05-16 12:33:44 +00:00
codecov[bot] commented 2023-05-16 12:36:14 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #226 (ca515ac) into main (84ed73b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   93.60%   93.62%   +0.01%     
==========================================
  Files          80       82       +2     
  Lines        3458     3465       +7     
  Branches      650      650              
==========================================
+ Hits         3237     3244       +7     
  Misses        144      144              
  Partials       77       77
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 93.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
junifer/api/decorators.py 100.00% <ø> (ø)
junifer/api/functions.py 96.23% <ø> (ø)
junifer/datagrabber/aomic/__init__.py 100.00% <ø> (ø)
junifer/datagrabber/base.py 100.00% <ø> (ø)
junifer/datagrabber/pattern.py 97.93% <ø> (ø)
junifer/datagrabber/pattern_datalad.py 100.00% <ø> (ø)
junifer/markers/collection.py 100.00% <ø> (ø)
junifer/testing/datagrabbers.py 100.00% <ø> (ø)
junifer/testing/registry.py 100.00% <ø> (ø)
junifer/datagrabber/__init__.py 100.00% <100.00%> (ø)
... and 8 more
## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#226](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (ca515ac) into [main](https://app.codecov.io/gh/juaml/junifer/commit/84ed73b3c8e09734a53144ca7e8847faa3d6442f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (84ed73b) will **increase** coverage by `0.01%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/226/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #226 +/- ## ========================================== + Coverage 93.60% 93.62% +0.01% ========================================== Files 80 82 +2 Lines 3458 3465 +7 Branches 650 650 ========================================== + Hits 3237 3244 +7 Misses 144 144 Partials 77 77 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.62% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/api/decorators.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZGVjb3JhdG9ycy5weQ==) | `100.00% <ø> (ø)` | | | [junifer/api/functions.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZnVuY3Rpb25zLnB5) | `96.23% <ø> (ø)` | | | [junifer/datagrabber/aomic/\_\_init\_\_.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9hb21pYy9fX2luaXRfXy5weQ==) | `100.00% <ø> (ø)` | | | [junifer/datagrabber/base.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9iYXNlLnB5) | `100.00% <ø> (ø)` | | | [junifer/datagrabber/pattern.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9wYXR0ZXJuLnB5) | `97.93% <ø> (ø)` | | | [junifer/datagrabber/pattern\_datalad.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9wYXR0ZXJuX2RhdGFsYWQucHk=) | `100.00% <ø> (ø)` | | | [junifer/markers/collection.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2NvbGxlY3Rpb24ucHk=) | `100.00% <ø> (ø)` | | | [junifer/testing/datagrabbers.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci90ZXN0aW5nL2RhdGFncmFiYmVycy5weQ==) | `100.00% <ø> (ø)` | | | [junifer/testing/registry.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci90ZXN0aW5nL3JlZ2lzdHJ5LnB5) | `100.00% <ø> (ø)` | | | [junifer/datagrabber/\_\_init\_\_.py](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | ... and [8 more](https://app.codecov.io/gh/juaml/junifer/pull/226?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | |
github-actions[bot] commented 2023-05-16 12:40:10 +00:00 (Migrated from github.com)
Copy link
PR Preview Action v0.0.2-104-g84960126
🚀 Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-226/
on branch gh-pages at 2023-05-16 14:03 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v0.0.2-104-g84960126 :---: :rocket: Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-226/ on branch [`gh-pages`](https://github.com/juaml/junifer/tree/gh-pages) at 2023-05-16 14:03 UTC <!-- Sticky Pull Request Commentpr-preview -->
fraimondo (Migrated from github.com) approved these changes 2023-06-20 10:27:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
LeSasse
fraimondo
Labels
Clear labels   
CRITICAL
High Priority Issue

  
Stale

   
WIP
Work in progress

  
bug
Something isn't working

  
concept
Design/Implementation concepts

  
coordinate
Issues or pull requests related to coordinates (ROIs)

  
dataset
Issues or pull requests related to datagrabbers or datasets

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
maintenance
Issues or pull requests related to maintenance

  
maps
Issues or pull requests related to maps (probabilistic atlases)

  
marker
Issues or pull requests related to markers

  
mask
Issues or pull requests related to masks

  
on hold
Issue waiting on other issue(s)

  
parcellation
Issues or pull requests related to parcellations (deterministic atlases)

  
preprocess
Issues or pull requests related to preprocessors

  
question
Further information is requested

  
ready
Pull request is ready for review and merge

  
storage
Issues or pull requests related to marker storage or retrieval

  
template-space
Issues or pull requests related to template spaces

  
triage
New issues waiting to be reviewed

  
wontfix
This will not be worked on

No labels
CRITICAL
Stale
WIP
bug
concept
coordinate
dataset
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
maintenance
maps
marker
mask
on hold
parcellation
preprocess
question
ready
storage
template-space
triage
wontfix
Milestone
Clear milestone
No items
No milestone
0.0.3 (alpha 2)
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!226
No description provided.