juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

Add junifer to conda-forge #221

Merged
synchon merged 4 commits from chore/add-conda-info into main 2023-05-09 10:32:49 +00:00
Conversation 11 Commits 4 Files changed 2 +20 -1
synchon commented 2023-05-05 12:39:08 +00:00 (Migrated from github.com)
Copy link

Make junifer available via conda by adding recipe to conda-forge channel. This will enable users to install junifer via:

conda install -c conda-forge junifer
Make `junifer` available via `conda` by adding recipe to [conda-forge](https://conda-forge.org) channel. This will enable users to install `junifer` via: ```shell conda install -c conda-forge junifer ```
synchon commented 2023-04-14 16:14:43 +00:00 (Migrated from github.com)
Copy link

Follow https://github.com/conda-forge/staged-recipes/pull/22569.

Follow https://github.com/conda-forge/staged-recipes/pull/22569.
codecov[bot] commented 2023-05-05 12:42:14 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #221 (ff8b032) into main (32d010d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          80       80           
  Lines        3458     3458           
  Branches      653      653           
=======================================
  Hits         3237     3237           
  Misses        144      144           
  Partials       77       77
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/221?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#221](https://app.codecov.io/gh/juaml/junifer/pull/221?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (ff8b032) into [main](https://app.codecov.io/gh/juaml/junifer/commit/32d010d5119503cf8b05663020f7a3bd66e3a5ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (32d010d) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/221/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #221 +/- ## ======================================= Coverage 93.60% 93.60% ======================================= Files 80 80 Lines 3458 3458 Branches 653 653 ======================================= Hits 3237 3237 Misses 144 144 Partials 77 77 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more.
github-actions[bot] commented 2023-05-05 12:44:13 +00:00 (Migrated from github.com)
Copy link
PR Preview Action v0.0.2-53-g6da3efcf
Preview removed because the pull request was closed.
2023-05-09 10:38 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v0.0.2-53-g6da3efcf :---: Preview removed because the pull request was closed. 2023-05-09 10:38 UTC <!-- Sticky Pull Request Commentpr-preview -->
LeSasse (Migrated from github.com) requested changes 2023-05-08 10:38:15 +00:00
README.md
LeSasse (Migrated from github.com) commented 2023-05-08 10:37:32 +00:00
Copy link

Would it make sense to let users know that there may be some issues with git-annex/datalad on macs?

Would it make sense to let users know that there may be some issues with git-annex/datalad on macs?
docs/installation.rst
@ -48,6 +48,19 @@ Use ``pip`` to install julearn from `PyPI <https://pypi.org>`_, like so:
pip install junifer
You can also install via ``conda``, like so:
LeSasse (Migrated from github.com) commented 2023-05-08 10:37:57 +00:00
Copy link

Same as above: Would it make sense to let users know that there may be some issues with git-annex/datalad on macs?

Same as above: Would it make sense to let users know that there may be some issues with git-annex/datalad on macs?
synchon (Migrated from github.com) reviewed 2023-05-08 10:41:41 +00:00
README.md
synchon (Migrated from github.com) commented 2023-05-08 10:41:41 +00:00
Copy link

Yeah of course, I'll make the changes.

Yeah of course, I'll make the changes.
fraimondo (Migrated from github.com) reviewed 2023-05-08 12:55:24 +00:00
README.md
fraimondo (Migrated from github.com) commented 2023-05-08 12:55:24 +00:00
Copy link

which issues?

I use to have issues, but not recently.

which issues? I use to have issues, but not recently.
synchon (Migrated from github.com) reviewed 2023-05-08 13:04:28 +00:00
README.md
synchon (Migrated from github.com) commented 2023-05-08 13:04:28 +00:00
Copy link

I think it's best to keep the information in the docs and skip it in the README for brevity. What do you think @LeSasse ?

I think it's best to keep the information in the docs and skip it in the README for brevity. What do you think @LeSasse ?
synchon (Migrated from github.com) reviewed 2023-05-08 13:05:50 +00:00
docs/installation.rst
@ -48,6 +48,19 @@ Use ``pip`` to install julearn from `PyPI <https://pypi.org>`_, like so:
pip install junifer
You can also install via ``conda``, like so:
synchon (Migrated from github.com) commented 2023-05-08 13:05:50 +00:00
Copy link

I have addressed it in the latest commit.

I have addressed it in the latest commit.
synchon (Migrated from github.com) reviewed 2023-05-08 13:08:14 +00:00
README.md
synchon (Migrated from github.com) commented 2023-05-08 13:08:13 +00:00
Copy link

which issues?

I use to have issues, but not recently.

Installation failure on Apple Silicon and also git-annex only available for linux on conda-forge. I already had a chat with the datalad folks and looks like they will come up with a fix.

> which issues? > > I use to have issues, but not recently. Installation failure on Apple Silicon and also git-annex only available for linux on conda-forge. I already had a chat with the datalad folks and looks like they will come up with a fix.
LeSasse (Migrated from github.com) reviewed 2023-05-08 13:52:26 +00:00
README.md
LeSasse (Migrated from github.com) commented 2023-05-08 13:52:21 +00:00
Copy link

I think it's best to keep the information in the docs and skip it in the README for brevity. What do you think @LeSasse ?

Yes makes sense to me, I think thats where most people will look at it anyhow.

> I think it's best to keep the information in the docs and skip it in the README for brevity. What do you think @LeSasse ? Yes makes sense to me, I think thats where most people will look at it anyhow.
LeSasse (Migrated from github.com) approved these changes 2023-05-09 10:30:57 +00:00
LeSasse (Migrated from github.com) left a comment
Copy link

Excellent work, let's merge this in pronto!

Excellent work, let's merge this in pronto!
Sign in to join this conversation.
Reviewers
No reviewers
LeSasse
Labels
Clear labels   
CRITICAL
High Priority Issue

  
Stale

   
WIP
Work in progress

  
bug
Something isn't working

  
concept
Design/Implementation concepts

  
coordinate
Issues or pull requests related to coordinates (ROIs)

  
dataset
Issues or pull requests related to datagrabbers or datasets

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
maintenance
Issues or pull requests related to maintenance

  
maps
Issues or pull requests related to maps (probabilistic atlases)

  
marker
Issues or pull requests related to markers

  
mask
Issues or pull requests related to masks

  
on hold
Issue waiting on other issue(s)

  
parcellation
Issues or pull requests related to parcellations (deterministic atlases)

  
preprocess
Issues or pull requests related to preprocessors

  
question
Further information is requested

  
ready
Pull request is ready for review and merge

  
storage
Issues or pull requests related to marker storage or retrieval

  
template-space
Issues or pull requests related to template spaces

  
triage
New issues waiting to be reviewed

  
wontfix
This will not be worked on

No labels
CRITICAL
Stale
WIP
bug
concept
coordinate
dataset
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
maintenance
maps
marker
mask
on hold
parcellation
preprocess
question
ready
storage
template-space
triage
wontfix
Milestone
Clear milestone
No items
No milestone
0.0.3 (alpha 2)
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!221
No description provided.