add extra input parameter to abstract aggregate method in fc base #200

Merged
LeSasse merged 6 commits from fix/fc_base_extra_input into main 2023-03-20 17:41:01 +00:00
LeSasse commented 2023-03-20 15:47:30 +00:00 (Migrated from github.com)
  • fix #(issue number)
  • description of feature/fix
  • tests added/passed
  • add an entry to the latest changes
* [ ] fix #(issue number) * [x] description of feature/fix * [ ] tests added/passed * [x] add an entry to the [latest changes](../docs/changes/latest.inc)
github-actions[bot] commented 2023-03-20 15:53:03 +00:00 (Migrated from github.com)
PR Preview Action v1.3.0
Preview removed because the pull request was closed.
2023-03-20 17:44 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.3.0 :---: Preview removed because the pull request was closed. 2023-03-20 17:44 UTC <!-- Sticky Pull Request Commentpr-preview -->
codecov[bot] commented 2023-03-20 15:53:14 +00:00 (Migrated from github.com)

Codecov Report

Merging #200 (b10e4eb) into main (927d630) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files          80       80           
  Lines        3351     3351           
  Branches      619      619           
=======================================
  Hits         3125     3125           
  Misses        151      151           
  Partials       75       75           
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 93.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ional_connectivity/functional_connectivity_base.py 97.05% <100.00%> (ø)
## [Codecov](https://codecov.io/gh/juaml/junifer/pull/200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#200](https://codecov.io/gh/juaml/junifer/pull/200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (b10e4eb) into [main](https://codecov.io/gh/juaml/junifer/commit/927d630a8263d4970a12ea418a6c00189d16df4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (927d630) will **not change** coverage. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/200/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #200 +/- ## ======================================= Coverage 93.25% 93.25% ======================================= Files 80 80 Lines 3351 3351 Branches 619 619 ======================================= Hits 3125 3125 Misses 151 151 Partials 75 75 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.24% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [...ional\_connectivity/functional\_connectivity\_base.py](https://codecov.io/gh/juaml/junifer/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2Z1bmN0aW9uYWxfY29ubmVjdGl2aXR5L2Z1bmN0aW9uYWxfY29ubmVjdGl2aXR5X2Jhc2UucHk=) | `97.05% <100.00%> (ø)` | |
fraimondo (Migrated from github.com) requested changes 2023-03-20 16:08:45 +00:00
fraimondo (Migrated from github.com) commented 2023-03-20 16:08:33 +00:00
(:gh:`200` by`Leonard Sasse`_)
``` (:gh:`200` by`Leonard Sasse`_) ```
fraimondo (Migrated from github.com) reviewed 2023-03-20 16:12:14 +00:00
fraimondo commented 2023-03-20 16:12:36 +00:00 (Migrated from github.com)

wait for the CI and then we can merge

wait for the CI and then we can merge
synchon (Migrated from github.com) approved these changes 2023-03-20 17:12:28 +00:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!200
No description provided.