[BUG]: allow for empty parcels in ParcelAggregation #194

Merged

fraimondo merged 3 commits from fix/empty_parcel into main

2023-03-20 14:58:55 +00:00

fraimondo commented

2023-03-16 13:56:14 +00:00

(Migrated from github.com)

Currently, subjects in which a parcel has 0 voxels will result in different sized vectors/matrix/timeseries, which will later fail on collect.

As with spheres, we should allow for "empty" parcels and compute the corresponding NAN value.

Currently, subjects in which a parcel has 0 voxels will result in different sized vectors/matrix/timeseries, which will later fail on collect. As with spheres, we should allow for "empty" parcels and compute the corresponding NAN value.

github-actions[bot] commented

2023-03-16 14:02:46 +00:00

(Migrated from github.com)

PR Preview Action v1.3.0
Preview removed because the pull request was closed.
2023-03-20 15:02 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.3.0 :---: Preview removed because the pull request was closed. 2023-03-20 15:02 UTC

codecov[bot] commented

2023-03-20 11:29:46 +00:00

(Migrated from github.com)

Codecov Report

Merging #194 (ef4f96c) into main (58fbbe4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   93.39%   93.41%   +0.01%     
==========================================
  Files          80       80              
  Lines        3348     3355       +7     
  Branches      609      615       +6     
==========================================
+ Hits         3127     3134       +7     
  Misses        148      148              
  Partials       73       73

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`93.40% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/markers/parcel_aggregation.py	`100.00% <100.00%> (ø)`

## [Codecov](https://codecov.io/gh/juaml/junifer/pull/194?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#194](https://codecov.io/gh/juaml/junifer/pull/194?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (ef4f96c) into [main](https://codecov.io/gh/juaml/junifer/commit/58fbbe44810c538b46340bc817d159fcba12d390?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (58fbbe4) will **increase** coverage by `0.01%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/194/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #194 +/- ## ========================================== + Coverage 93.39% 93.41% +0.01% ========================================== Files 80 80 Lines 3348 3355 +7 Branches 609 615 +6 ========================================== + Hits 3127 3134 +7 Misses 148 148 Partials 73 73 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.40% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/markers/parcel\_aggregation.py](https://codecov.io/gh/juaml/junifer/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL3BhcmNlbF9hZ2dyZWdhdGlvbi5weQ==) | `100.00% <100.00%> (ø)` | |

synchon (Migrated from github.com) requested changes

2023-03-20 11:58:18 +00:00

docs/changes/latest.inc