Add extra_input to reho/falff #187

Merged

fraimondo merged 2 commits from fix/extra_input into main

2023-03-14 22:11:37 +00:00

fraimondo commented

2023-03-14 21:28:26 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry to the latest changes

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry to the [latest changes](../docs/changes/latest.inc)

codecov[bot] commented

2023-03-14 21:32:41 +00:00

(Migrated from github.com)

Codecov Report

Merging #187 (6d8deab) into main (1747177) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          80       80           
  Lines        3208     3208           
  Branches      583      583           
=======================================
  Hits         3013     3013           
  Misses        129      129           
  Partials       66       66

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`93.91% <80.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/markers/falff/falff_base.py	`74.35% <50.00%> (ø)`
junifer/markers/falff/falff_parcels.py	`100.00% <100.00%> (ø)`
junifer/markers/falff/falff_spheres.py	`100.00% <100.00%> (ø)`
junifer/markers/reho/reho_parcels.py	`92.00% <100.00%> (ø)`
junifer/markers/reho/reho_spheres.py	`92.30% <100.00%> (ø)`

## [Codecov](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#187](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (6d8deab) into [main](https://codecov.io/gh/juaml/junifer/commit/17471775b598303eb94008e25c38e24efd4c2dfc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (1747177) will **not change** coverage. > The diff coverage is `80.00%`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/187/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #187 +/- ## ======================================= Coverage 93.92% 93.92% ======================================= Files 80 80 Lines 3208 3208 Branches 583 583 ======================================= Hits 3013 3013 Misses 129 129 Partials 66 66 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.91% <80.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/markers/falff/falff\_base.py](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2ZhbGZmL2ZhbGZmX2Jhc2UucHk=) | `74.35% <50.00%> (ø)` | | | [junifer/markers/falff/falff\_parcels.py](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2ZhbGZmL2ZhbGZmX3BhcmNlbHMucHk=) | `100.00% <100.00%> (ø)` | | | [junifer/markers/falff/falff\_spheres.py](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2ZhbGZmL2ZhbGZmX3NwaGVyZXMucHk=) | `100.00% <100.00%> (ø)` | | | [junifer/markers/reho/reho\_parcels.py](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL3JlaG8vcmVob19wYXJjZWxzLnB5) | `92.00% <100.00%> (ø)` | | | [junifer/markers/reho/reho\_spheres.py](https://codecov.io/gh/juaml/junifer/pull/187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL3JlaG8vcmVob19zcGhlcmVzLnB5) | `92.30% <100.00%> (ø)` | |

github-actions[bot] commented

2023-03-14 21:33:50 +00:00

(Migrated from github.com)

PR Preview Action v1.3.0
Preview removed because the pull request was closed.
2023-03-14 22:16 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.3.0 :---: Preview removed because the pull request was closed. 2023-03-14 22:16 UTC

synchon (Migrated from github.com) reviewed

2023-03-14 21:37:10 +00:00

synchon (Migrated from github.com) approved these changes

2023-03-14 21:46:58 +00:00