[ENH]: Rename 'table' to 'vector' in storage API #181

Merged

synchon merged 51 commits from refactor/storage/table-to-vector into main

2023-02-17 12:51:26 +00:00

synchon commented

2023-02-13 10:14:43 +00:00

(Migrated from github.com)

Are you requiring a new dataset or marker?

I understand this is not a marker or dataset request

Which feature do you want to include?

Currently we support:

Storing matrixes (named columns and rows, same dimensions for all elements)
Storing timeseries (named columns with variable number of rows, depending on the element)
Storing tables (same as timeseries, but the rows are not named "timepoint" but exposed to the user)

We are using "tables" to store "vectors". That is, 1 dimentional arrays. However, we have a whole logic set to allow for tables with different number of rows per element, as in timeseries. This does not make any sense. We should support:

matrixes
timeseries
vectors

How do you imagine this integrated in junifer?

rename "table" to vector and make them 1d arrays
remove row_col_names from store_vector

extra:
be consistent with col_names and row_names. Currently timeseries and vectors will have a columns parameter, while matrix has col_names and row_names

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

### Are you requiring a new dataset or marker? - [X] I understand this is not a marker or dataset request ### Which feature do you want to include? Currently we support: 1) Storing matrixes (named columns and rows, same dimensions for all elements) 2) Storing timeseries (named columns with variable number of rows, depending on the element) 3) Storing tables (same as timeseries, but the rows are not named "timepoint" but exposed to the user) We are using "tables" to store "vectors". That is, 1 dimentional arrays. However, we have a whole logic set to allow for tables with different number of rows per element, as in timeseries. This does not make any sense. We should support: 1) matrixes 2) timeseries 3) vectors ### How do you imagine this integrated in junifer? 1) rename "table" to vector and make them 1d arrays 2) remove `row_col_names` from `store_vector` extra: be consistent with `col_names` and `row_names`. Currently timeseries and vectors will have a `columns` parameter, while matrix has `col_names` and `row_names` ### Do you have a sample code that implements this outside of junifer? _No response_ ### Anything else to say? _No response_

codecov[bot] commented

2023-02-13 10:15:45 +00:00

(Migrated from github.com)

Codecov Report

Merging #181 (d8089ab) into main (9cf5a62) will decrease coverage by 0.03%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   93.51%   93.48%   -0.03%     
==========================================
  Files          75       75              
  Lines        2866     2871       +5     
  Branches      515      519       +4     
==========================================
+ Hits         2680     2684       +4     
  Misses        126      126              
- Partials       60       61       +1

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`93.48% <91.30%> (-0.02%)`	⬇️
mock	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/markers/falff/falff_parcels.py	`100.00% <ø> (ø)`
junifer/markers/falff/falff_spheres.py	`100.00% <ø> (ø)`
...ivity/crossparcellation_functional_connectivity.py	`100.00% <ø> (ø)`
junifer/markers/reho/reho_parcels.py	`92.00% <ø> (ø)`
junifer/markers/reho/reho_spheres.py	`92.30% <ø> (ø)`
junifer/storage/base.py	`81.81% <80.00%> (ø)`
junifer/storage/sqlite.py	`94.53% <80.00%> (ø)`
junifer/storage/pandas_base.py	`95.55% <90.00%> (-1.75%)`	⬇️
junifer/data/masks.py	`95.00% <100.00%> (ø)`
junifer/markers/ets_rss.py	`100.00% <100.00%> (ø)`
... and 9 more

# [Codecov](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#181](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (d8089ab) into [main](https://codecov.io/gh/juaml/junifer/commit/9cf5a629f09fa4ad758221223dfa661aefdafc6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (9cf5a62) will **decrease** coverage by `0.03%`. > The diff coverage is `91.30%`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/181/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================== - Coverage 93.51% 93.48% -0.03% ========================================== Files 75 75 Lines 2866 2871 +5 Branches 515 519 +4 ========================================== + Hits 2680 2684 +4 Misses 126 126 - Partials 60 61 +1 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.48% <91.30%> (-0.02%)` | :arrow_down: | | mock | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/markers/falff/falff\_parcels.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2ZhbGZmL2ZhbGZmX3BhcmNlbHMucHk=) | `100.00% <ø> (ø)` | | | [junifer/markers/falff/falff\_spheres.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2ZhbGZmL2ZhbGZmX3NwaGVyZXMucHk=) | `100.00% <ø> (ø)` | | | [...ivity/crossparcellation\_functional\_connectivity.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2Z1bmN0aW9uYWxfY29ubmVjdGl2aXR5L2Nyb3NzcGFyY2VsbGF0aW9uX2Z1bmN0aW9uYWxfY29ubmVjdGl2aXR5LnB5) | `100.00% <ø> (ø)` | | | [junifer/markers/reho/reho\_parcels.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL3JlaG8vcmVob19wYXJjZWxzLnB5) | `92.00% <ø> (ø)` | | | [junifer/markers/reho/reho\_spheres.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL3JlaG8vcmVob19zcGhlcmVzLnB5) | `92.30% <ø> (ø)` | | | [junifer/storage/base.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL2Jhc2UucHk=) | `81.81% <80.00%> (ø)` | | | [junifer/storage/sqlite.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL3NxbGl0ZS5weQ==) | `94.53% <80.00%> (ø)` | | | [junifer/storage/pandas\_base.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL3BhbmRhc19iYXNlLnB5) | `95.55% <90.00%> (-1.75%)` | :arrow_down: | | [junifer/data/masks.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL21hc2tzLnB5) | `95.00% <100.00%> (ø)` | | | [junifer/markers/ets\_rss.py](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2V0c19yc3MucHk=) | `100.00% <100.00%> (ø)` | | | ... and [9 more](https://codecov.io/gh/juaml/junifer/pull/181?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | |

github-actions[bot] commented

2023-02-13 14:08:19 +00:00

(Migrated from github.com)

PR Preview Action v1.3.0
Preview removed because the pull request was closed.
2023-02-17 12:55 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.3.0 :---: Preview removed because the pull request was closed. 2023-02-17 12:55 UTC

fraimondo (Migrated from github.com) approved these changes

2023-02-17 12:50:12 +00:00