[ENH]: Homotopic AICHA parcellation (version 2) #173

Merged

synchon merged 11 commits from feat/aicha-parcellation into main

2023-07-06 06:42:10 +00:00

synchon commented

2023-07-05 13:49:43 +00:00

(Migrated from github.com)

Are you requiring a new dataset or marker?

I understand this is not a marker or dataset request

Which feature do you want to include?

One parcellation that we like to use in a number of projects is the second version of the AICHA atlas (2021) because it is homotopic (find it here: https://www.gin.cnrs.fr/en/tools/aicha/). I checked with the parcellations that are planned as built in parcellations and it is not included there (https://juaml.github.io/junifer/main/builtin.html#id4). It might make sense to include it.

How do you imagine this integrated in junifer?

similar to other parcellations

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

### Are you requiring a new dataset or marker? - [X] I understand this is not a marker or dataset request ### Which feature do you want to include? One parcellation that we like to use in a number of projects is the second version of the AICHA atlas (2021) because it is homotopic (find it here: https://www.gin.cnrs.fr/en/tools/aicha/). I checked with the parcellations that are planned as built in parcellations and it is not included there (https://juaml.github.io/junifer/main/builtin.html#id4). It might make sense to include it. ### How do you imagine this integrated in junifer? similar to other parcellations ### Do you have a sample code that implements this outside of junifer? _No response_ ### Anything else to say? _No response_

LeSasse (Migrated from github.com) reviewed

2023-07-05 13:49:43 +00:00

codecov[bot] commented

2023-07-05 14:10:19 +00:00

(Migrated from github.com)

Codecov Report

Merging #173 (f2620ad) into main (602ea62) will decrease coverage by 0.09%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   93.57%   93.49%   -0.09%     
==========================================
  Files          82       82              
  Lines        3471     3518      +47     
  Branches      644      659      +15     
==========================================
+ Hits         3248     3289      +41     
- Misses        146      148       +2     
- Partials       77       81       +4

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`93.48% <88.23%> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/api/cli.py	`69.14% <ø> (ø)`
junifer/data/parcellations.py	`96.09% <88.23%> (-2.00%)`	⬇️

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/173?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#173](https://app.codecov.io/gh/juaml/junifer/pull/173?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (f2620ad) into [main](https://app.codecov.io/gh/juaml/junifer/commit/602ea62f236e85261ed497a8b95de6f9aedb38b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (602ea62) will **decrease** coverage by `0.09%`. > The diff coverage is `88.23%`. [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/173/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #173 +/- ## ========================================== - Coverage 93.57% 93.49% -0.09% ========================================== Files 82 82 Lines 3471 3518 +47 Branches 644 659 +15 ========================================== + Hits 3248 3289 +41 - Misses 146 148 +2 - Partials 77 81 +4 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.48% <88.23%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/juaml/junifer/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/api/cli.py](https://app.codecov.io/gh/juaml/junifer/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvY2xpLnB5) | `69.14% <ø> (ø)` | | | [junifer/data/parcellations.py](https://app.codecov.io/gh/juaml/junifer/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL3BhcmNlbGxhdGlvbnMucHk=) | `96.09% <88.23%> (-2.00%)` | :arrow_down: |

fraimondo (Migrated from github.com) reviewed

2023-07-05 14:53:02 +00:00