[ENH]: Optimize HCP datagrabbers tests to improve CI running time. #155

Merged

fraimondo merged 5 commits from enh/optimize_hcp1200_tests into main

2023-01-23 11:50:20 +00:00

fraimondo commented

2023-01-23 08:51:04 +00:00

(Migrated from github.com)

Are you requiring a new dataset or marker?

I understand this is not a marker or dataset request

Which feature do you want to include?

Currently we test HCP1200Datagrabber through the DataladHCP1200Datagrabber. This takes a lot of time as we do many clone/get.

How do you imagine this integrated in junifer?

Proposal:

Test DataladHCP1200Datagrabber only in one case.
Clone, get all files, and then test HCP1200Datagrabber. This should be faster.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

### Are you requiring a new dataset or marker? - [X] I understand this is not a marker or dataset request ### Which feature do you want to include? Currently we test `HCP1200Datagrabber` through the `DataladHCP1200Datagrabber`. This takes a lot of time as we do many clone/get. ### How do you imagine this integrated in junifer? Proposal: - Test `DataladHCP1200Datagrabber` only in one case. - Clone, get all files, and then test `HCP1200Datagrabber`. This should be faster. ### Do you have a sample code that implements this outside of junifer? _No response_ ### Anything else to say? _No response_

codecov[bot] commented

2023-01-23 08:52:52 +00:00

(Migrated from github.com)

Codecov Report

Merging #155 (8583634) into main (6a0ffef) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          75       75           
  Lines        2836     2836           
  Branches      508      508           
=======================================
  Hits         2650     2650           
  Misses        126      126           
  Partials       60       60

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`
junifer	`93.43% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/datagrabber/hcp.py	`100.00% <100.00%> (ø)`

# [Codecov](https://codecov.io/gh/juaml/junifer/pull/155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#155](https://codecov.io/gh/juaml/junifer/pull/155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (8583634) into [main](https://codecov.io/gh/juaml/junifer/commit/6a0ffefaf1ec2af4254a6d22ad3bfdea0bcd8728?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (6a0ffef) will **not change** coverage. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/155/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #155 +/- ## ======================================= Coverage 93.44% 93.44% ======================================= Files 75 75 Lines 2836 2836 Branches 508 508 ======================================= Hits 2650 2650 Misses 126 126 Partials 60 60 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `93.43% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/datagrabber/hcp.py](https://codecov.io/gh/juaml/junifer/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhZ3JhYmJlci9oY3AucHk=) | `100.00% <100.00%> (ø)` | |

github-actions[bot] commented

2023-01-23 08:57:27 +00:00

(Migrated from github.com)

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2023-01-23 11:56 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.2.0 :---: Preview removed because the pull request was closed. 2023-01-23 11:56 UTC

synchon (Migrated from github.com) approved these changes

2023-01-23 11:48:49 +00:00