update: improve marker and storage interfaces #149

Merged

fraimondo merged 28 commits from fix/meta into main 2022-11-29 12:08:23 +00:00

Conversation 4 Commits 28 Files changed 73 +1626 -1337

fraimondo commented 2022-11-29 08:51:02 +00:00 (Migrated from github.com)

Copy link

• fix issues with meta and the storage interfaces
• description of feature/fix
• tests added/passed
• add an entry to the latest changes

* [x] fix issues with meta and the storage interfaces * [ ] description of feature/fix * [x] tests added/passed * [ ] add an entry to the [latest changes](../docs/changes/latest.inc)

codecov[bot] commented 2022-11-29 08:53:36 +00:00 (Migrated from github.com)

Copy link

Codecov Report

Merging #149 (7775cde) into main (9a199e9) will decrease coverage by 0.03%.
The diff coverage is 96.65%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   95.17%   95.14%   -0.04%     
==========================================
  Files          59       60       +1     
  Lines        2364     2347      -17     
  Branches      447      447              
==========================================
- Hits         2250     2233      -17     
- Misses         73       75       +2     
+ Partials       41       39       -2     

Flag	Coverage Δ
docs	100.00% <ø> (ø)
junifer	95.13% <96.65%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/api/cli.py	75.00% <ø> (ø)
junifer/data/coordinates.py	100.00% <ø> (ø)
junifer/markers/collection.py	100.00% <ø> (ø)
junifer/pipeline/registry.py	100.00% <ø> (ø)
junifer/testing/registry.py	100.00% <ø> (ø)
junifer/data/masks.py	91.83% <66.66%> (ø)
junifer/storage/base.py	81.81% <80.95%> (-12.30%)	⬇️
junifer/preprocess/base.py	86.84% <88.88%> (-1.53%)	⬇️
junifer/storage/pandas_base.py	97.29% <95.65%> (-2.71%)	⬇️
junifer/api/functions.py	98.03% <100.00%> (ø)
... and 23 more

# [Codecov](https://codecov.io/gh/juaml/junifer/pull/149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#149](https://codecov.io/gh/juaml/junifer/pull/149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (7775cde) into [main](https://codecov.io/gh/juaml/junifer/commit/9a199e97a6ed41339e8daf23b67aacb6bbdc9935?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (9a199e9) will **decrease** coverage by `0.03%`. > The diff coverage is `96.65%`. [](https://codecov.io/gh/juaml/junifer/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #149 +/- ## ========================================== - Coverage 95.17% 95.14% -0.04% ========================================== Files 59 60 +1 Lines 2364 2347 -17 Branches 447 447 ========================================== - Hits 2250 2233 -17 - Misses 73 75 +2 + Partials 41 39 -2 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `95.13% <96.65%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/api/cli.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvY2xpLnB5) | `75.00% <ø> (ø)` | | | [junifer/data/coordinates.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL2Nvb3JkaW5hdGVzLnB5) | `100.00% <ø> (ø)` | | | [junifer/markers/collection.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9tYXJrZXJzL2NvbGxlY3Rpb24ucHk=) | `100.00% <ø> (ø)` | | | [junifer/pipeline/registry.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9waXBlbGluZS9yZWdpc3RyeS5weQ==) | `100.00% <ø> (ø)` | | | [junifer/testing/registry.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci90ZXN0aW5nL3JlZ2lzdHJ5LnB5) | `100.00% <ø> (ø)` | | | [junifer/data/masks.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9kYXRhL21hc2tzLnB5) | `91.83% <66.66%> (ø)` | | | [junifer/storage/base.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL2Jhc2UucHk=) | `81.81% <80.95%> (-12.30%)` | :arrow_down: | | [junifer/preprocess/base.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9wcmVwcm9jZXNzL2Jhc2UucHk=) | `86.84% <88.88%> (-1.53%)` | :arrow_down: | | [junifer/storage/pandas\_base.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9zdG9yYWdlL3BhbmRhc19iYXNlLnB5) | `97.29% <95.65%> (-2.71%)` | :arrow_down: | | [junifer/api/functions.py](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZnVuY3Rpb25zLnB5) | `98.03% <100.00%> (ø)` | | | ... and [23 more](https://codecov.io/gh/juaml/junifer/pull/149/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | |

fraimondo (Migrated from github.com) reviewed 2022-11-29 09:21:30 +00:00

fraimondo (Migrated from github.com) left a comment

Copy link

I'm pushing a few changes, but it's OK for me.

I'm pushing a few changes, but it's OK for me.

github-actions[bot] commented 2022-11-29 10:44:18 +00:00 (Migrated from github.com)

Copy link

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2022-11-29 12:13 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.2.0 :---: Preview removed because the pull request was closed. 2022-11-29 12:13 UTC <!-- Sticky Pull Request Commentpr-preview -->

synchon (Migrated from github.com) approved these changes 2022-11-29 12:08:12 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

synchon

Labels

Clear labels   

CRITICAL

High Priority Issue

  

Stale

  

WIP

Work in progress

  

bug

Something isn't working

  

concept

Design/Implementation concepts

  

coordinate

Issues or pull requests related to coordinates (ROIs)

  

dataset

Issues or pull requests related to datagrabbers or datasets

  

dependencies

Pull requests that update a dependency file

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

github_actions

Pull requests that update GitHub Actions code

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

maintenance

Issues or pull requests related to maintenance

  

maps

Issues or pull requests related to maps (probabilistic atlases)

  

marker

Issues or pull requests related to markers

  

mask

Issues or pull requests related to masks

  

on hold

Issue waiting on other issue(s)

  

parcellation

Issues or pull requests related to parcellations (deterministic atlases)

  

preprocess

Issues or pull requests related to preprocessors

  

question

Further information is requested

  

ready

Pull request is ready for review and merge

  

storage

Issues or pull requests related to marker storage or retrieval

  

template-space

Issues or pull requests related to template spaces

  

triage

New issues waiting to be reviewed

  

wontfix

This will not be worked on

No labels

CRITICAL

Stale

WIP

bug

concept

coordinate

dataset

dependencies

documentation

duplicate

enhancement

github_actions

good first issue

help wanted

invalid

maintenance

maps

marker

mask

on hold

parcellation

preprocess

question

ready

storage

template-space

triage

wontfix

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

juaml/junifer!149

No description provided.