[ENH]: Add test for `JuniferNiftiSpheresMasker` against nilearn's version #136

Merged

synchon merged 8 commits from update/junifer-nifti-spheres-masker into main

2024-06-18 16:16:35 +00:00

synchon commented

2024-06-12 15:49:34 +00:00

(Migrated from github.com)

Are you requiring a new dataset or marker?

I understand this is not a marker or dataset request

Which feature do you want to include?

We reimplemented (by copying) a JuniferNiftiSpheresMasker that has the same functionality of NiftiSpheresMasker but allows to change the aggregation function.

The tests are also a copy of Nilearn's one.

If agg_function = 'mean', then they should both behave equally. I would like to have a test so we can corroborate this. They should be numerically equal.

How do you imagine this integrated in junifer?

One more test in junifer.external.nilearn.tests

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

### Are you requiring a new dataset or marker? - [X] I understand this is not a marker or dataset request ### Which feature do you want to include? We reimplemented (by copying) a `JuniferNiftiSpheresMasker` that has the same functionality of `NiftiSpheresMasker` but allows to change the aggregation function. The tests are also a copy of Nilearn's one. If `agg_function = 'mean'`, then they should both behave equally. I would like to have a test so we can corroborate this. They should be numerically equal. ### How do you imagine this integrated in junifer? One more test in `junifer.external.nilearn.tests` ### Do you have a sample code that implements this outside of junifer? _No response_ ### Anything else to say? _No response_

fraimondo commented

2023-03-14 14:54:06 +00:00

(Migrated from github.com)

For the moment, let's fix 0.10.0 as the latest supported nilearn version.

Onces 0.10.1 is released, let's add the tests and version-specific patches.

For the moment, let's fix 0.10.0 as the latest supported nilearn version. Onces 0.10.1 is released, let's add the tests and version-specific patches.

codecov[bot] commented

2024-06-12 15:50:15 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d501374) to head (e205953).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/136?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 100.00%. Comparing base [(`d501374`)](https://app.codecov.io/gh/juaml/junifer/commit/d50137428497b795a4fd4d24a572f6620affb20e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`e205953`)](https://app.codecov.io/gh/juaml/junifer/commit/e205953b5b850f507b332b3da0b499cdcdab87ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/136/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #136 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 1 1 ========================================= Hits 1 1 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/136/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/136/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. </details>

github-actions[bot] commented

2024-06-12 16:12:20 +00:00

(Migrated from github.com)

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-18 16:36 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.7 :---: Preview removed because the pull request was closed. 2024-06-18 16:36 UTC

synchon commented

2024-06-12 16:26:08 +00:00

(Migrated from github.com)

#347 needs to go in before this as that sets the proper nilearn version we need for this, #333 and #335