[DOC]: Fill in built-in coordinates list #120

Merged
synchon merged 4 commits from docs/coordinates-list into main 2022-11-24 14:05:12 +00:00
synchon commented 2022-11-24 11:07:44 +00:00 (Migrated from github.com)

Which element of the documentation do you want to modify and why?

Like Parcellations (https://juaml.github.io/junifer/main/builtin.html) but for Coordinates

Anything else to say?

No response

### Which element of the documentation do you want to modify and why? Like Parcellations (https://juaml.github.io/junifer/main/builtin.html) but for Coordinates ### Anything else to say? _No response_
synchon commented 2022-11-15 07:21:00 +00:00 (Migrated from github.com)

@fraimondo I can tackle this one. I went through the brainspheres project but I couldn't find the references and the formal names for the coordinates. Maybe I didn't look enough, but it would be great if you already have them somewhere handy.

@fraimondo I can tackle this one. I went through the `brainspheres` project but I couldn't find the references and the formal names for the coordinates. Maybe I didn't look enough, but it would be great if you already have them somewhere handy.
codecov[bot] commented 2022-11-24 11:07:56 +00:00 (Migrated from github.com)

Codecov Report

Merging #120 (67daaef) into main (98db0a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          59       59           
  Lines        2364     2364           
  Branches      447      447           
=======================================
  Hits         2250     2250           
  Misses         73       73           
  Partials       41       41           
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 95.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

# [Codecov](https://codecov.io/gh/juaml/junifer/pull/120?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#120](https://codecov.io/gh/juaml/junifer/pull/120?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (67daaef) into [main](https://codecov.io/gh/juaml/junifer/commit/98db0a46a4d3c676bebec6416663274976bf2ddd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (98db0a4) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/120/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #120 +/- ## ======================================= Coverage 95.17% 95.17% ======================================= Files 59 59 Lines 2364 2364 Branches 447 447 ======================================= Hits 2250 2250 Misses 73 73 Partials 41 41 ``` | Flag | Coverage Δ | | |---|---|---| | docs | `100.00% <ø> (ø)` | | | junifer | `95.16% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more.
github-actions[bot] commented 2022-11-24 11:13:05 +00:00 (Migrated from github.com)
PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2022-11-24 14:09 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.2.0 :---: Preview removed because the pull request was closed. 2022-11-24 14:09 UTC <!-- Sticky Pull Request Commentpr-preview -->
synchon commented 2022-11-24 12:09:53 +00:00 (Migrated from github.com)

We need to anyway update the list later. For now, it has as much information we have available.

We need to anyway update the list later. For now, it has as much information we have available.
fraimondo commented 2022-11-24 13:14:33 +00:00 (Migrated from github.com)

@synchon We have 15 coordinates in the VOIs/meta directory, why only 9 in the available and 3 in the planned?

They are all available, problem is that we don't have the right documentation?

@synchon We have 15 coordinates in the `VOIs/meta` directory, why only 9 in the available and 3 in the planned? They are all available, problem is that we don't have the right documentation?
synchon commented 2022-11-24 13:16:17 +00:00 (Migrated from github.com)

@synchon We have 15 coordinates in the VOIs/meta directory, why only 9 in the available and 3 in the planned?

They are all available, problem is that we don't have the right documentation?

Yes, exactly.

> @synchon We have 15 coordinates in the `VOIs/meta` directory, why only 9 in the available and 3 in the planned? > > They are all available, problem is that we don't have the right documentation? Yes, exactly.
fraimondo commented 2022-11-24 13:16:40 +00:00 (Migrated from github.com)

Or either we:

  1. Remove for the moment
  2. Add in the doc that we don't have the details yet.
Or either we: 1. Remove for the moment 2. Add in the doc that we don't have the details yet.
synchon commented 2022-11-24 13:17:26 +00:00 (Migrated from github.com)

Or either we:

  1. Remove for the moment
  2. Add in the doc that we don't have the details yet.
  1. sounds good to me.
> Or either we: > > 1. Remove for the moment > 2. Add in the doc that we don't have the details yet. 2. sounds good to me.
synchon commented 2022-11-24 13:50:24 +00:00 (Migrated from github.com)

I have added as much as I can with some more info.

I have added as much as I can with some more info.
fraimondo (Migrated from github.com) approved these changes 2022-11-24 13:54:55 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!120
No description provided.