diff --git a/docs/changes/newsfragments/312.bugfix b/docs/changes/newsfragments/312.bugfix new file mode 100644 index 000000000..a43ff95a1 --- /dev/null +++ b/docs/changes/newsfragments/312.bugfix @@ -0,0 +1 @@ +Fix :class:`.HTCondorAdapter`'s script generation to use double quotes instead of single quotes for HTCondor's ``VARS`` by `Synchon Mandal`_ diff --git a/junifer/api/queue_context/htcondor_adapter.py b/junifer/api/queue_context/htcondor_adapter.py index 96d590dae..63899e13f 100644 --- a/junifer/api/queue_context/htcondor_adapter.py +++ b/junifer/api/queue_context/htcondor_adapter.py @@ -274,8 +274,8 @@ class HTCondorAdapter(QueueContextAdapter): ) fixed += ( f"JOB run{idx} {self._submit_run_path}\n" - f"VARS run{idx} element='{str_element}' " - f"log_element='{log_element}'\n\n" + f'VARS run{idx} element="{str_element}" ' # needs to be + f'log_element="{log_element}"\n\n' # double quoted ) var = "" if self._collect == "yes": diff --git a/junifer/api/queue_context/tests/test_htcondor_adapter.py b/junifer/api/queue_context/tests/test_htcondor_adapter.py index f0c048d6d..cf41e6d9e 100644 --- a/junifer/api/queue_context/tests/test_htcondor_adapter.py +++ b/junifer/api/queue_context/tests/test_htcondor_adapter.py @@ -139,13 +139,13 @@ def test_HTCondorAdapter_run_collect( ( [("sub01", "ses01")], "yes", - "element='sub01,ses01' log_element='sub01-ses01'", + 'element="sub01,ses01" log_element="sub01-ses01"', ), (["sub01"], "on_success_only", "JOB collect"), ( [("sub01", "ses01")], "on_success_only", - "element='sub01,ses01' log_element='sub01-ses01'", + 'element="sub01,ses01" log_element="sub01-ses01"', ), ], )