diff --git a/docs/changes/latest.inc b/docs/changes/latest.inc index f7e833622..2c5e7267f 100644 --- a/docs/changes/latest.inc +++ b/docs/changes/latest.inc @@ -81,6 +81,8 @@ Bugs - Fix a bug in which :class:`junifer.markers.ParcelAggregation` could yield duplicated column names if two or more parcels were used and label names were not unique (:gh:`194` by `Fede Raimondo`_). +- Fix a bug in which :func:`junifer.data.masks.get_mask` fails for FunctionalConnectivityBase class, because of missing extra_input parameter (:gh:`200` by `Leonard Sasse`_) + API changes ~~~~~~~~~~~ diff --git a/junifer/markers/functional_connectivity/functional_connectivity_base.py b/junifer/markers/functional_connectivity/functional_connectivity_base.py index dbabe6bd1..72f7ad135 100644 --- a/junifer/markers/functional_connectivity/functional_connectivity_base.py +++ b/junifer/markers/functional_connectivity/functional_connectivity_base.py @@ -66,7 +66,11 @@ class FunctionalConnectivityBase(BaseMarker): super().__init__(on="BOLD", name=name) @abstractmethod - def aggregate(self, input: Dict[str, Any]) -> Dict[str, Any]: + def aggregate( + self, + input: Dict[str, Any], + extra_input: Optional[Dict[str, Any]] = None, + ) -> Dict[str, Any]: """Perform aggregation.""" raise_error( msg="Concrete classes need to implement aggregate().", @@ -130,7 +134,7 @@ class FunctionalConnectivityBase(BaseMarker): """ # Perform necessary aggregation - aggregation = self.aggregate(input) + aggregation = self.aggregate(input, extra_input=extra_input) # Compute correlation if self.cor_method_params["empirical"]: connectivity = ConnectivityMeasure(