[ENH]: Add support for BrainPrint #344

2024-05-16T14:14:00Z

synchon commented

2024-05-16 14:14:00 +00:00

(Migrated from github.com)

description of feature/fix
tests added/passed
add an entry for the latest changes

This PR adds support for BrainPrint marker.

* [x] description of feature/fix * [x] tests added/passed * [x] add an entry for the latest changes This PR adds support for `BrainPrint` marker.

codecov[bot] commented

2024-05-16 14:14:37 +00:00

(Migrated from github.com)

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (30a6900) to head (5a53992).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #344   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1

Flag	Coverage Δ
docs	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/344?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 100.00%. Comparing base [(`30a6900`)](https://app.codecov.io/gh/juaml/junifer/commit/30a6900db23ddf4a72bf505112f1efd73c173bca?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) to head [(`5a53992`)](https://app.codecov.io/gh/juaml/junifer/pull/344?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml). <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/344/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #344 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 1 1 ========================================= Hits 1 1 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/344/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. </details>

github-actions[bot] commented

2024-05-17 11:10:00 +00:00

(Migrated from github.com)

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-03 09:29 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.7 :---: Preview removed because the pull request was closed. 2024-06-03 09:29 UTC

fraimondo (Migrated from github.com) approved these changes

2024-05-28 08:19:40 +00:00

junifer/markers/tests/test_brainprint.py

					
				@ -0,0 +29,4 @@

				    _check_freesurfer() is False, reason="requires FreeSurfer to be in PATH"

				)

				@pytest.mark.skipif(

				    socket.gethostname() != "juseless",

Why only for juseless?

synchon (Migrated from github.com) reviewed

2024-06-03 09:08:18 +00:00

junifer/markers/tests/test_brainprint.py

					
				@ -0,0 +29,4 @@

				    _check_freesurfer() is False, reason="requires FreeSurfer to be in PATH"

				)

				@pytest.mark.skipif(

				    socket.gethostname() != "juseless",

The data takes quite some time to fetch and the computation is better half of an hour, so would exceed the limitations of the gh-actions standard runners. We can pull it off on gh-actions if we have a small testing dataset providing FreeSurfer derivatives.

Sign in to join this conversation.

No reviewers

fraimondo