juaml/junifer
Watch
3
0
Fork
You've already forked junifer
 0
Code Issues 14 Pull requests 2 Packages Activity Actions

[ENH]: Bump dependencies #253

Merged
fraimondo merged 5 commits from maint/update_deps into main 2023-10-04 14:01:38 +00:00
Conversation 8 Commits 5 Files changed 7 +46 -40
fraimondo commented 2023-10-04 11:58:49 +00:00 (Migrated from github.com)
Copy link

Are you requiring a new dataset or marker?

  • I understand this is not a marker or dataset request

Which feature do you want to include?

New packages have been published for:

numpy: 1.26.0
datalad: 0.19.3
pandas: 2.1.1
nibabel: 5.10
nilearn: 0.10.1
sqlalchemy: 2.0.21
h5py: 3.9

Also testing/docs packages versions should be updated.

How do you imagine this integrated in junifer?

Update pyproject.toml

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

### Are you requiring a new dataset or marker? - [X] I understand this is not a marker or dataset request ### Which feature do you want to include? New packages have been published for: `numpy`: 1.26.0 `datalad`: 0.19.3 `pandas`: 2.1.1 `nibabel`: 5.10 `nilearn`: 0.10.1 `sqlalchemy`: 2.0.21 `h5py`: 3.9 Also testing/docs packages versions should be updated. ### How do you imagine this integrated in junifer? Update `pyproject.toml` ### Do you have a sample code that implements this outside of junifer? _No response_ ### Anything else to say? _No response_
codecov[bot] commented 2023-10-04 11:59:21 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #253 (9b25866) into main (e3e9423) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          84       84           
  Lines        3714     3714           
  Branches      722      722           
=======================================
  Hits         3458     3458           
  Misses        160      160           
  Partials       96       96
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...r/external/nilearn/junifer_nifti_spheres_masker.py 93.33% <ø> (ø)
## [Codecov](https://app.codecov.io/gh/juaml/junifer/pull/253?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#253](https://app.codecov.io/gh/juaml/junifer/pull/253?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (9b25866) into [main](https://app.codecov.io/gh/juaml/junifer/commit/e3e942324b2f90f103a8500105e123d664139737?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (e3e9423) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/253/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #253 +/- ## ======================================= Coverage 93.10% 93.10% ======================================= Files 84 84 Lines 3714 3714 Branches 722 722 ======================================= Hits 3458 3458 Misses 160 160 Partials 96 96 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/253/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/253/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/junifer/pull/253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [...r/external/nilearn/junifer\_nifti\_spheres\_masker.py](https://app.codecov.io/gh/juaml/junifer/pull/253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9leHRlcm5hbC9uaWxlYXJuL2p1bmlmZXJfbmlmdGlfc3BoZXJlc19tYXNrZXIucHk=) | `93.33% <ø> (ø)` | |
synchon (Migrated from github.com) requested changes 2023-10-04 12:03:18 +00:00
synchon (Migrated from github.com) left a comment
Copy link

Can we also update the conda-env.yml and the installation docs?

Can we also update the `conda-env.yml` and the installation docs?
fraimondo (Migrated from github.com) reviewed 2023-10-04 12:04:29 +00:00
github-actions[bot] commented 2023-10-04 12:05:06 +00:00 (Migrated from github.com)
Copy link
PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-04 14:07 UTC
[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.4.4 :---: Preview removed because the pull request was closed. 2023-10-04 14:07 UTC <!-- Sticky Pull Request Commentpr-preview -->
synchon (Migrated from github.com) reviewed 2023-10-04 12:05:55 +00:00
synchon (Migrated from github.com) reviewed 2023-10-04 12:10:21 +00:00
conda-env.yml
@ -3,23 +3,23 @@ channels:
- conda-forge
synchon (Migrated from github.com) commented 2023-10-04 12:10:20 +00:00
Copy link

sphinx and not phinx?

`sphinx` and not `phinx`?
fraimondo (Migrated from github.com) reviewed 2023-10-04 12:12:35 +00:00
conda-env.yml
@ -3,23 +3,23 @@ channels:
- conda-forge
fraimondo (Migrated from github.com) commented 2023-10-04 12:12:35 +00:00
Copy link

bad copy paste

bad copy paste
synchon (Migrated from github.com) approved these changes 2023-10-04 12:13:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
synchon
Labels
Clear labels   
CRITICAL
High Priority Issue

  
Stale

   
WIP
Work in progress

  
bug
Something isn't working

  
concept
Design/Implementation concepts

  
coordinate
Issues or pull requests related to coordinates (ROIs)

  
dataset
Issues or pull requests related to datagrabbers or datasets

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
maintenance
Issues or pull requests related to maintenance

  
maps
Issues or pull requests related to maps (probabilistic atlases)

  
marker
Issues or pull requests related to markers

  
mask
Issues or pull requests related to masks

  
on hold
Issue waiting on other issue(s)

  
parcellation
Issues or pull requests related to parcellations (deterministic atlases)

  
preprocess
Issues or pull requests related to preprocessors

  
question
Further information is requested

  
ready
Pull request is ready for review and merge

  
storage
Issues or pull requests related to marker storage or retrieval

  
template-space
Issues or pull requests related to template spaces

  
triage
New issues waiting to be reviewed

  
wontfix
This will not be worked on

No labels
CRITICAL
Stale
WIP
bug
concept
coordinate
dataset
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
maintenance
maps
marker
mask
on hold
parcellation
preprocess
question
ready
storage
template-space
triage
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
juaml/junifer!253
No description provided.