Feat/import #129

2022-11-15T08:47:42Z

fraimondo commented

2022-11-15 08:47:42 +00:00

(Migrated from github.com)

new feature: allow for file imports in with statement in yaml file
description of feature/fix
TODO: tests in #110
No need to add an entry to the latest changes, feature not documented yet.

* [x] new feature: allow for file imports in `with` statement in yaml file * [x] description of feature/fix * [ ] TODO: tests in #110 * [ ] No need to add an entry to the [latest changes](../docs/changes/latest.inc), feature not documented yet.

github-actions[bot] commented

2022-11-15 08:53:14 +00:00

(Migrated from github.com)

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2022-11-15 10:32 UTC

[PR Preview Action](https://github.com/rossjrw/pr-preview-action) v1.2.0 :---: Preview removed because the pull request was closed. 2022-11-15 10:32 UTC

codecov[bot] commented

2022-11-15 08:58:28 +00:00

(Migrated from github.com)

Codecov Report

Merging #129 (315c4eb) into main (19ecaa2) will decrease coverage by 1.16%.
The diff coverage is 19.51%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   92.18%   91.01%   -1.17%     
==========================================
  Files          57       57              
  Lines        2226     2260      +34     
  Branches      414      424      +10     
==========================================
+ Hits         2052     2057       +5     
- Misses        136      163      +27     
- Partials       38       40       +2

Flag	Coverage Δ
junifer	`91.00% <19.51%> (-1.17%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
junifer/api/functions.py	`36.24% <5.26%> (-3.32%)`	⬇️
junifer/api/cli.py	`75.00% <20.00%> (-3.95%)`	⬇️
junifer/api/parser.py	`69.44% <35.29%> (-30.56%)`	⬇️

# [Codecov](https://codecov.io/gh/juaml/junifer/pull/129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) Report > Merging [#129](https://codecov.io/gh/juaml/junifer/pull/129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (315c4eb) into [main](https://codecov.io/gh/juaml/junifer/commit/19ecaa29dc4bc1ec2751a74ab4b4df1ab02e290c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) (19ecaa2) will **decrease** coverage by `1.16%`. > The diff coverage is `19.51%`. [![Impacted file tree graph](https://codecov.io/gh/juaml/junifer/pull/129/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://codecov.io/gh/juaml/junifer/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #129 +/- ## ========================================== - Coverage 92.18% 91.01% -1.17% ========================================== Files 57 57 Lines 2226 2260 +34 Branches 414 424 +10 ========================================== + Hits 2052 2057 +5 - Misses 136 163 +27 - Partials 38 40 +2 ``` | Flag | Coverage Δ | | |---|---|---| | junifer | `91.00% <19.51%> (-1.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/juaml/junifer/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [junifer/api/functions.py](https://codecov.io/gh/juaml/junifer/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvZnVuY3Rpb25zLnB5) | `36.24% <5.26%> (-3.32%)` | :arrow_down: | | [junifer/api/cli.py](https://codecov.io/gh/juaml/junifer/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvY2xpLnB5) | `75.00% <20.00%> (-3.95%)` | :arrow_down: | | [junifer/api/parser.py](https://codecov.io/gh/juaml/junifer/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVuaWZlci9hcGkvcGFyc2VyLnB5) | `69.44% <35.29%> (-30.56%)` | :arrow_down: |

synchon (Migrated from github.com) requested changes

2022-11-15 09:32:38 +00:00

synchon (Migrated from github.com) left a comment

One small comment, else looks good.

junifer/api/functions.py

					
				@ -426,6 +454,7 @@ def _queue_slurm(

				    jobdir: Path,

Newline not required?

synchon (Migrated from github.com) approved these changes

2022-11-15 10:21:58 +00:00

Sign in to join this conversation.

No reviewers

synchon

No labels

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

juaml/junifer!129

				`@ -426,6 +454,7 @@ def _queue_slurm(`
				`jobdir: Path,`

Rows
Columns